* [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe
@ 2025-03-28 6:29 Jeevan B
2025-03-28 8:10 ` Sharma, Swati2
0 siblings, 1 reply; 2+ messages in thread
From: Jeevan B @ 2025-03-28 6:29 UTC (permalink / raw)
To: igt-dev; +Cc: Jeevan B
Having this check after igt_output_set_pipe causes a commit failure,
so we need to check intel_pipe_output_combo_valid before setting pipe.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_display_modes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index 588820170..3e388bb33 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -199,12 +199,12 @@ static void run_extendedmode_test(data_t *data) {
igt_display_reset(display);
- igt_output_set_pipe(output1, pipe1);
- igt_output_set_pipe(output2, pipe2);
-
if (!intel_pipe_output_combo_valid(display))
continue;
+ igt_output_set_pipe(output1, pipe1);
+ igt_output_set_pipe(output2, pipe2);
+
igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
kmstest_pipe_name(pipe1),
igt_output_name(output1),
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe
2025-03-28 6:29 [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe Jeevan B
@ 2025-03-28 8:10 ` Sharma, Swati2
0 siblings, 0 replies; 2+ messages in thread
From: Sharma, Swati2 @ 2025-03-28 8:10 UTC (permalink / raw)
To: Jeevan B, igt-dev
Hi Jeevan,
On 28-03-2025 11:59 am, Jeevan B wrote:
> Having this check after igt_output_set_pipe causes a commit failure,
> so we need to check intel_pipe_output_combo_valid before setting pipe.
We need to set_pipe() first and then check intel_pipe_output_combo_valid().
W/o setting pipe, we won't know if pipe/output combo is valid or not.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_display_modes.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index 588820170..3e388bb33 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -199,12 +199,12 @@ static void run_extendedmode_test(data_t *data) {
>
> igt_display_reset(display);
>
> - igt_output_set_pipe(output1, pipe1);
> - igt_output_set_pipe(output2, pipe2);
> -
> if (!intel_pipe_output_combo_valid(display))
> continue;
>
> + igt_output_set_pipe(output1, pipe1);
> + igt_output_set_pipe(output2, pipe2);
> +
> igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
> kmstest_pipe_name(pipe1),
> igt_output_name(output1),
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-28 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 6:29 [PATCH i-g-t] tests/kms_display_modes: Move intel_pipe_output_combo_valid before igt_output_set_pipe Jeevan B
2025-03-28 8:10 ` Sharma, Swati2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox