Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH V2 i-g-t] test/amdgpu: add apu check for pciplug test
@ 2023-11-07  3:37 Jesse Zhang
  2023-11-07  4:37 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Jesse Zhang @ 2023-11-07  3:37 UTC (permalink / raw)
  To: igt-dev; +Cc: Tim Huang, Luben Tuikov, Alex Deucher, Christian Koenig

For apu, it is integrated with cpu.
So hotplug test should be unnecessary for it.

V2:
 -IGT built-in approach to check this condition
   in the fixture function. (Vitlay)

Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Tim Huang <tim.huang@amd.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
---
 tests/amdgpu/amd_pci_unplug.c | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/tests/amdgpu/amd_pci_unplug.c b/tests/amdgpu/amd_pci_unplug.c
index 4c055b99f..22e053795 100644
--- a/tests/amdgpu/amd_pci_unplug.c
+++ b/tests/amdgpu/amd_pci_unplug.c
@@ -30,15 +30,42 @@
 #include "lib/amdgpu/amd_pci_unplug.h"
 #include "lib/amdgpu/amd_ip_blocks.h"
 
+static bool
+is_hot_plug_test_enable(amdgpu_device_handle device_handle, const struct amdgpu_gpu_info *gpu_info)
+{
+	bool enable = true;
+
+		/* skip hotplug test on APUs */
+	if (gpu_info->ids_flags & AMDGPU_IDS_FLAGS_FUSION) {
+		igt_info("Don't support hot plug on APUs, hot plug test is disabled\n");
+		enable = false;
+	}
+	return enable;
+}
 
 igt_main
 {
 
 	struct amd_pci_unplug_setup setup = {0};
 	struct amd_pci_unplug unplug = {0};
+	amdgpu_device_handle device;
+	struct amdgpu_gpu_info gpu_info = {};
+	int fd = -1;
 
 	igt_fixture {
+		uint32_t major, minor;
+		int err;
+
+		fd = drm_open_driver(DRIVER_AMDGPU);
+		err = amdgpu_device_initialize(fd, &major, &minor, &device);
+		igt_require(err == 0);
+		igt_info("Initialized amdgpu, driver version %d.%d\n",
+			 major, minor);
+		err = amdgpu_query_gpu_info(device, &gpu_info);
+		igt_assert_eq(err, 0);
+
 		setup.minor_version_req = 46;
+		igt_skip_on(!is_hot_plug_test_enable(device, &gpu_info));
 	}
 
 	igt_subtest("amdgpu_hotunplug_simple")
@@ -54,5 +81,8 @@ igt_main
 	igt_subtest("amdgpu_hotunplug_with_exported_fence")
 		amdgpu_hotunplug_with_exported_fence(&setup, &unplug);
 
-	igt_fixture { }
+	igt_fixture {
+		amdgpu_device_deinitialize(device);
+		drm_close_driver(fd);
+	}
 }
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-07 18:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07  3:37 [igt-dev] [PATCH V2 i-g-t] test/amdgpu: add apu check for pciplug test Jesse Zhang
2023-11-07  4:37 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-11-07  4:38 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-11-07  9:12 ` [igt-dev] [PATCH V2 i-g-t] " Kamil Konieczny
2023-11-07 18:31   ` vitaly prosyak
2023-11-07 12:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox