* [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
@ 2024-08-09 20:06 Frank Li
2024-08-10 11:46 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Frank Li @ 2024-08-09 20:06 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ioana Ciornei,
open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Add missed property phys, which indicate how connect to serdes phy.
Fix below warning:
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
index 6538e0ce90b28..25d657be6956f 100644
--- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
@@ -38,6 +38,10 @@ properties:
managed: true
+ phys:
+ description: A reference to the SerDes lane(s)
+ maxItems: 1
+
required:
- reg
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
2024-08-09 20:06 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys Frank Li
@ 2024-08-10 11:46 ` Krzysztof Kozlowski
2024-08-10 21:56 ` Frank Li
2024-08-11 12:25 ` Krzysztof Kozlowski
2024-08-12 12:30 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-10 11:46 UTC (permalink / raw)
To: Frank Li, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ioana Ciornei, open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 09/08/2024 22:06, Frank Li wrote:
> Add missed property phys, which indicate how connect to serdes phy.
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> index 6538e0ce90b28..25d657be6956f 100644
> --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> @@ -38,6 +38,10 @@ properties:
>
> managed: true
>
> + phys:
> + description: A reference to the SerDes lane(s)
This is not the same phy as phy-handle points to?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
2024-08-10 11:46 ` Krzysztof Kozlowski
@ 2024-08-10 21:56 ` Frank Li
0 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2024-08-10 21:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ioana Ciornei,
open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Sat, Aug 10, 2024 at 01:46:25PM +0200, Krzysztof Kozlowski wrote:
> On 09/08/2024 22:06, Frank Li wrote:
> > Add missed property phys, which indicate how connect to serdes phy.
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > index 6538e0ce90b28..25d657be6956f 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > @@ -38,6 +38,10 @@ properties:
> >
> > managed: true
> >
> > + phys:
> > + description: A reference to the SerDes lane(s)
>
> This is not the same phy as phy-handle points to?
I go through source code and dts, it is not the same. phys connect to chip
internal serdas phys. phy-handle points to external ethernet phy, which is
connected by mdio bus generally.
Frank
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
2024-08-09 20:06 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys Frank Li
2024-08-10 11:46 ` Krzysztof Kozlowski
@ 2024-08-11 12:25 ` Krzysztof Kozlowski
2024-08-12 12:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-11 12:25 UTC (permalink / raw)
To: Frank Li, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ioana Ciornei, open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 09/08/2024 22:06, Frank Li wrote:
> Add missed property phys, which indicate how connect to serdes phy.
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
2024-08-09 20:06 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys Frank Li
2024-08-10 11:46 ` Krzysztof Kozlowski
2024-08-11 12:25 ` Krzysztof Kozlowski
@ 2024-08-12 12:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-12 12:30 UTC (permalink / raw)
To: Frank Li
Cc: davem, edumazet, kuba, pabeni, robh, krzk+dt, conor+dt,
ioana.ciornei, netdev, devicetree, linux-kernel, imx
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 9 Aug 2024 16:06:53 -0400 you wrote:
> Add missed property phys, which indicate how connect to serdes phy.
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
Here is the summary with links:
- [1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
https://git.kernel.org/netdev/net/c/c25504a0ba36
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-12 12:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 20:06 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys Frank Li
2024-08-10 11:46 ` Krzysztof Kozlowski
2024-08-10 21:56 ` Frank Li
2024-08-11 12:25 ` Krzysztof Kozlowski
2024-08-12 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox