[PATCH 1/2] dt-bindings: media: imx219: Rename to include vendor prefix

[PATCH 1/2] dt-bindings: media: imx219: Rename to include vendor prefix

[David Heidelberg]

imx219.yaml doesn't include the vendor prefix of sony,
so rename to add it.

Update the id entry and MAINTAINERS to match.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../bindings/media/i2c/{imx219.yaml => sony,imx219.yaml}        | 2 +-
 MAINTAINERS                                                     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/media/i2c/{imx219.yaml => sony,imx219.yaml} (97%)

diff --git ./Documentation/devicetree/bindings/media/i2c/imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
similarity index 97%
rename from Documentation/devicetree/bindings/media/i2c/imx219.yaml
rename to Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
index 07d088cf66e0..8b23e5fc6a24 100644
--- ./Documentation/devicetree/bindings/media/i2c/imx219.yaml
+++ ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/media/i2c/imx219.yaml#
+$id: http://devicetree.org/schemas/media/i2c/sony,imx219.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Sony 1/4.0-Inch 8Mpixel CMOS Digital Image Sensor
diff --git ./MAINTAINERS ./MAINTAINERS
index 453ba75fce3b..32a4d057a559 100644
--- ./MAINTAINERS
+++ ./MAINTAINERS
@@ -21796,7 +21796,7 @@ M:	Dave Stevenson <dave.stevenson@raspberrypi.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media.git
-F:	Documentation/devicetree/bindings/media/i2c/imx219.yaml
+F:	Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
 F:	drivers/media/i2c/imx219.c
 
 SONY IMX258 SENSOR DRIVER
-- 
2.45.2

[PATCH 2/2] dt-bindings: media: imx219: Describe sensor address using the reg property

[David Heidelberg]

Use the reg property instead of text in the description.
Drop useless description of reg property.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
index 8b23e5fc6a24..066eeb7af5e3 100644
--- ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
+++ ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
@@ -12,7 +12,7 @@ maintainers:
 description: |-
   The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor
   with an active array size of 3280H x 2464V. It is programmable through
-  I2C interface. The I2C address is fixed to 0x10 as per sensor data sheet.
+  I2C interface.
   Image data is sent through MIPI CSI-2, which is configured as either 2 or
   4 data lanes.
 
@@ -21,8 +21,7 @@ properties:
     const: sony,imx219
 
   reg:
-    description: I2C device address
-    maxItems: 1
+    const: 0x10
 
   clocks:
     maxItems: 1
-- 
2.45.2

Re: [PATCH 1/2] dt-bindings: media: imx219: Rename to include vendor prefix

[Krzysztof Kozlowski]

On 17/12/2024 03:41, David Heidelberg wrote:
> imx219.yaml doesn't include the vendor prefix of sony,
> so rename to add it.
> 
> Update the id entry and MAINTAINERS to match.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../bindings/media/i2c/{imx219.yaml => sony,imx219.yaml}        | 2 +-
>  MAINTAINERS                                                     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename Documentation/devicetree/bindings/media/i2c/{imx219.yaml => sony,imx219.yaml} (97%)

If you are doing changes like this, fix entire subsystem so all bindings
there. Not one file.

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: media: imx219: Describe sensor address using the reg property

[Krzysztof Kozlowski]

On Mon, Dec 16, 2024 at 09:41:51PM -0500, David Heidelberg wrote:
> Use the reg property instead of text in the description.
> Drop useless description of reg property.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml

You are using non-standard tools to generate patches. See checkpatch
warnings.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: media: imx219: Describe sensor address using the reg property

[David Heidelberg]

Oh, the checkpatch script keeps warning me every time I commit—I guess 
it needs to be addressed.

I currently use:

[diff]
   srcprefix = ./
   dstprefix = ./

Originally, my intention was to use:

[diff]
   noprefix = true

This was to make it easier to copy-paste directly into the shell (git 
log -p, etc.). However, it ended up breaking too many applications. 
Setting srcprefix and dstprefix instead keeps everything working properly.

Is there any chance a patch allowing a ./ prefix could make it into 
checkpatch? What do you think, Krzysztof?

Thank you,
David

On 17/12/2024 02:40, Krzysztof Kozlowski wrote:
> On Mon, Dec 16, 2024 at 09:41:51PM -0500, David Heidelberg wrote:
>> Use the reg property instead of text in the description.
>> Drop useless description of reg property.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
> 
> You are using non-standard tools to generate patches. See checkpatch
> warnings.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

-- 
David Heidelberg