From: "Rob Herring (Arm)" <robh@kernel.org>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: linux-remoteproc@vger.kernel.org, andersson@kernel.org,
devicetree@vger.kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, conor+dt@kernel.org,
iuliana.prodan@nxp.com, Frank.Li@nxp.com,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
p.zabel@pengutronix.de, krzk+dt@kernel.org,
laurentiu.mihalcea@nxp.com, linux-kernel@vger.kernel.org,
mathieu.poirier@linaro.org, shengjiu.wang@nxp.com,
kernel@pengutronix.de, peng.fan@nxp.com, festevam@gmail.com
Subject: Re: [PATCH v4 2/8] dt-bindings: dsp: fsl,dsp: Add resets property
Date: Wed, 5 Mar 2025 11:05:12 -0600 [thread overview]
Message-ID: <174119431164.2143223.3829886855063677866.robh@kernel.org> (raw)
In-Reply-To: <20250305100037.373782-3-daniel.baluta@nxp.com>
On Wed, 05 Mar 2025 12:00:30 +0200, Daniel Baluta wrote:
> Assert and deassert functionality of the DSP found on i.MX8MP is
> realized by combining control bits from two modules: Audio Block
> Control and Debug Access Port.
>
> Audio block control bits are used to Run/Stall the DSP core
> while the DAP bits are used for software reset the core.
>
> The original plan was to use fsl,dsp-ctrl property and to refer the
> audiomix bits via syscon interface. This proposal received NACK from
> community we shouldn't abuse the syscon interface [1].
>
> So remove fsl,dsp-ctrl property for i.MX8MP and use reset control
> interface instead.
>
> Example dts node only uses runstall control now, but softreset will
> be added in the future when we will convert the softreset functionality
> to use reset controller API.
>
> [1] https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.baluta@nxp.com/
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> .../devicetree/bindings/dsp/fsl,dsp.yaml | 24 ++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-03-05 17:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 10:00 [PATCH v4 0/8] imx8mp: Add support to Run/Stall DSP via reset API Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 2/8] dt-bindings: dsp: fsl,dsp: Add resets property Daniel Baluta
2025-03-05 17:05 ` Rob Herring (Arm) [this message]
2025-03-05 10:00 ` [PATCH v4 3/8] arm64: dts: imx8mp: Use " Daniel Baluta
2025-03-06 5:31 ` Peng Fan
2025-03-05 10:00 ` [PATCH v4 4/8] reset: imx8mp-audiomix: Add prefix for internal macro Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits Daniel Baluta
2025-03-06 5:31 ` Peng Fan
2025-03-05 10:00 ` [PATCH v4 6/8] reset: imx8mp-audiomix: Introduce active_low configuration option Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall Daniel Baluta
2025-03-06 5:31 ` Peng Fan
2025-03-05 10:00 ` [PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control the DSP Daniel Baluta
2025-03-10 15:42 ` Mathieu Poirier
2025-03-11 8:59 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174119431164.2143223.3829886855063677866.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=iuliana.prodan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurentiu.mihalcea@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox