From: Daniel Baluta <daniel.baluta@nxp.com>
To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org,
shawnguo@kernel.org, mathieu.poirier@linaro.org,
devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org
Cc: conor+dt@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, andersson@kernel.org,
Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com,
iuliana.prodan@nxp.com, shengjiu.wang@nxp.com,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: [PATCH v4 4/8] reset: imx8mp-audiomix: Add prefix for internal macro
Date: Wed, 5 Mar 2025 12:00:32 +0200 [thread overview]
Message-ID: <20250305100037.373782-5-daniel.baluta@nxp.com> (raw)
In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com>
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show
that specific macros are related to audiomix.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
index 6e3f3069f727..c2c3e8113182 100644
--- a/drivers/reset/reset-imx8mp-audiomix.c
+++ b/drivers/reset/reset-imx8mp-audiomix.c
@@ -11,8 +11,8 @@
#include <linux/of_address.h>
#include <linux/reset-controller.h>
-#define EARC 0x200
-#define EARC_RESET_MASK 0x3
+#define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200
+#define IMX8MP_AUDIOMIX_EARC_RESET_MASK 0x3
struct imx8mp_audiomix_reset {
struct reset_controller_dev rcdev;
@@ -35,8 +35,8 @@ static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev,
mask = BIT(id);
spin_lock_irqsave(&priv->lock, flags);
- reg = readl(reg_addr + EARC);
- writel(reg & ~mask, reg_addr + EARC);
+ reg = readl(reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET);
+ writel(reg & ~mask, reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET);
spin_unlock_irqrestore(&priv->lock, flags);
return 0;
@@ -52,8 +52,8 @@ static int imx8mp_audiomix_reset_deassert(struct reset_controller_dev *rcdev,
mask = BIT(id);
spin_lock_irqsave(&priv->lock, flags);
- reg = readl(reg_addr + EARC);
- writel(reg | mask, reg_addr + EARC);
+ reg = readl(reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET);
+ writel(reg | mask, reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET);
spin_unlock_irqrestore(&priv->lock, flags);
return 0;
@@ -78,7 +78,7 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary_device *adev,
spin_lock_init(&priv->lock);
priv->rcdev.owner = THIS_MODULE;
- priv->rcdev.nr_resets = fls(EARC_RESET_MASK);
+ priv->rcdev.nr_resets = fls(IMX8MP_AUDIOMIX_EARC_RESET_MASK);
priv->rcdev.ops = &imx8mp_audiomix_reset_ops;
priv->rcdev.of_node = dev->parent->of_node;
priv->rcdev.dev = dev;
--
2.43.0
next prev parent reply other threads:[~2025-03-05 10:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 10:00 [PATCH v4 0/8] imx8mp: Add support to Run/Stall DSP via reset API Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 2/8] dt-bindings: dsp: fsl,dsp: Add resets property Daniel Baluta
2025-03-05 17:05 ` Rob Herring (Arm)
2025-03-05 10:00 ` [PATCH v4 3/8] arm64: dts: imx8mp: Use " Daniel Baluta
2025-03-06 5:31 ` Peng Fan
2025-03-05 10:00 ` Daniel Baluta [this message]
2025-03-05 10:00 ` [PATCH v4 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits Daniel Baluta
2025-03-06 5:31 ` Peng Fan
2025-03-05 10:00 ` [PATCH v4 6/8] reset: imx8mp-audiomix: Introduce active_low configuration option Daniel Baluta
2025-03-05 10:00 ` [PATCH v4 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall Daniel Baluta
2025-03-06 5:31 ` Peng Fan
2025-03-05 10:00 ` [PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control the DSP Daniel Baluta
2025-03-10 15:42 ` Mathieu Poirier
2025-03-11 8:59 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305100037.373782-5-daniel.baluta@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=iuliana.prodan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurentiu.mihalcea@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox