* [PATCH 2/4] dt-bindings: net: fec: add iommus property
2024-01-29 21:18 [PATCH 1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property Frank Li
@ 2024-01-29 21:18 ` Frank Li
2024-01-30 1:26 ` Wei Fang
2024-01-30 8:29 ` Krzysztof Kozlowski
2024-01-29 21:18 ` [PATCH 3/4] arm64: dts: imx8qm: add smmu node Frank Li
2024-01-29 21:18 ` [PATCH 4/4] arm64: dts: imx8qm: add smmu stream id information Frank Li
2 siblings, 2 replies; 6+ messages in thread
From: Frank Li @ 2024-01-29 21:18 UTC (permalink / raw)
To: ulf.hansson, robh+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, wei.fang, shenwei.wang, xiaoning.wang, davem,
edumazet, kuba, pabeni, imx
iMX95 and iMX8QM have iommu. Add proerty 'iommus'.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index 8948a11c994e4..5536c06139cae 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -224,6 +224,9 @@ properties:
Can be omitted thus no delay is observed. Delay is in range of 1ms to 1000ms.
Other delays are invalid.
+ iommus:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH 2/4] dt-bindings: net: fec: add iommus property
2024-01-29 21:18 ` [PATCH 2/4] dt-bindings: net: fec: " Frank Li
@ 2024-01-30 1:26 ` Wei Fang
2024-01-30 8:29 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Wei Fang @ 2024-01-30 1:26 UTC (permalink / raw)
To: Frank Li, ulf.hansson@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
Shenwei Wang, Clark Wang, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
imx@lists.linux.dev
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年1月30日 5:19
> To: ulf.hansson@linaro.org; robh+dt@kernel.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; Wei Fang
> <wei.fang@nxp.com>; Shenwei Wang <shenwei.wang@nxp.com>; Clark
> Wang <xiaoning.wang@nxp.com>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> imx@lists.linux.dev
> Subject: [PATCH 2/4] dt-bindings: net: fec: add iommus property
>
> iMX95 and iMX8QM have iommu. Add proerty 'iommus'.
>
i.MX95 does not have FEC port, so you should remove iMX95 from the commit
message. :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] dt-bindings: net: fec: add iommus property
2024-01-29 21:18 ` [PATCH 2/4] dt-bindings: net: fec: " Frank Li
2024-01-30 1:26 ` Wei Fang
@ 2024-01-30 8:29 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-30 8:29 UTC (permalink / raw)
To: Frank Li, ulf.hansson, robh+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, linux-imx, wei.fang, shenwei.wang,
xiaoning.wang, davem, edumazet, kuba, pabeni, imx
On 29/01/2024 22:18, Frank Li wrote:
> iMX95 and iMX8QM have iommu. Add proerty 'iommus'.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 3 +++
> 1 file changed, 3 insertions(+)
That's a really random CC list... not even made public, but sending to
some folks so only looking like a public posting.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts_getmaintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, use mainline), work on fork of kernel (don't, use
mainline) or you ignore some maintainers (really don't). Just use b4 and
everything should be fine, although remember about `b4 prep
--auto-to-cc` if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/4] arm64: dts: imx8qm: add smmu node
2024-01-29 21:18 [PATCH 1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property Frank Li
2024-01-29 21:18 ` [PATCH 2/4] dt-bindings: net: fec: " Frank Li
@ 2024-01-29 21:18 ` Frank Li
2024-01-29 21:18 ` [PATCH 4/4] arm64: dts: imx8qm: add smmu stream id information Frank Li
2 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2024-01-29 21:18 UTC (permalink / raw)
To: ulf.hansson, robh+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, wei.fang, shenwei.wang, xiaoning.wang, davem,
edumazet, kuba, pabeni, imx
Add smmu node for imx8qm.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 41 +++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index 31744fc1ab085..b3d01677b70c4 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -265,6 +265,47 @@ timer {
<GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */
};
+ smmu: iommu@51400000 {
+ compatible = "arm,mmu-500";
+ interrupt-parent = <&gic>;
+ reg = <0 0x51400000 0 0x40000>;
+ #global-interrupts = <1>;
+ #iommu-cells = <2>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+ };
+
system-controller {
compatible = "fsl,imx-scu";
mbox-names = "tx0",
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] arm64: dts: imx8qm: add smmu stream id information
2024-01-29 21:18 [PATCH 1/4] dt-bindings: mmc: fsl-imx-esdhc: add iommus property Frank Li
2024-01-29 21:18 ` [PATCH 2/4] dt-bindings: net: fec: " Frank Li
2024-01-29 21:18 ` [PATCH 3/4] arm64: dts: imx8qm: add smmu node Frank Li
@ 2024-01-29 21:18 ` Frank Li
2 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2024-01-29 21:18 UTC (permalink / raw)
To: ulf.hansson, robh+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-imx, wei.fang, shenwei.wang, xiaoning.wang, davem,
edumazet, kuba, pabeni, imx
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi
index ec1639174e2e5..3cbc861400b43 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-conn.dtsi
@@ -6,20 +6,26 @@
&fec1 {
compatible = "fsl,imx8qm-fec", "fsl,imx6sx-fec";
+ iommus = <&smmu 0x12 0x7f80>;
};
&fec2 {
compatible = "fsl,imx8qm-fec", "fsl,imx6sx-fec";
+ iommus = <&smmu 0x12 0x7f80>;
};
&usdhc1 {
compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+ iommus = <&smmu 0x11 0x7f80>;
};
&usdhc2 {
compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+ iommus = <&smmu 0x11 0x7f80>;
};
&usdhc3 {
compatible = "fsl,imx8qm-usdhc", "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+ iommus = <&smmu 0x11 0x7f80>;
};
+
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread