* [PATCH 1/1] dmaengine: fsl-edma: correct calculation of 'nbytes' in multi-fifo scenario
@ 2024-01-31 16:33 Frank Li
2024-02-07 8:49 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Frank Li @ 2024-01-31 16:33 UTC (permalink / raw)
To: Vinod Koul, open list:FREESCALE eDMA DRIVER,
open list:FREESCALE eDMA DRIVER, open list
From: Joy Zou <joy.zou@nxp.com>
The 'nbytes' should be equivalent to burst * width in audio multi-fifo
setups. Given that the FIFO width is fixed at 32 bits, adjusts the burst
size for multi-fifo configurations to match the slave maxburst in the
configuration.
Cc: stable@vger.kernel.org
Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support")
Signed-off-by: Joy Zou <joy.zou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/dma/fsl-edma-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index b53f46245c377..793f1a7ad5e34 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -503,7 +503,7 @@ void fsl_edma_fill_tcd(struct fsl_edma_chan *fsl_chan,
if (fsl_chan->is_multi_fifo) {
/* set mloff to support multiple fifo */
burst = cfg->direction == DMA_DEV_TO_MEM ?
- cfg->src_addr_width : cfg->dst_addr_width;
+ cfg->src_maxburst : cfg->dst_maxburst;
nbytes |= EDMA_V3_TCD_NBYTES_MLOFF(-(burst * 4));
/* enable DMLOE/SMLOE */
if (cfg->direction == DMA_MEM_TO_DEV) {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] dmaengine: fsl-edma: correct calculation of 'nbytes' in multi-fifo scenario
2024-01-31 16:33 [PATCH 1/1] dmaengine: fsl-edma: correct calculation of 'nbytes' in multi-fifo scenario Frank Li
@ 2024-02-07 8:49 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2024-02-07 8:49 UTC (permalink / raw)
To: imx, dmaengine, linux-kernel, Frank Li
On Wed, 31 Jan 2024 11:33:18 -0500, Frank Li wrote:
> The 'nbytes' should be equivalent to burst * width in audio multi-fifo
> setups. Given that the FIFO width is fixed at 32 bits, adjusts the burst
> size for multi-fifo configurations to match the slave maxburst in the
> configuration.
>
>
Applied, thanks!
[1/1] dmaengine: fsl-edma: correct calculation of 'nbytes' in multi-fifo scenario
commit: 9ba17defd9edd87970b701085402bc8ecc3a11d4
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-07 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-31 16:33 [PATCH 1/1] dmaengine: fsl-edma: correct calculation of 'nbytes' in multi-fifo scenario Frank Li
2024-02-07 8:49 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox