From: Xiaolei Wang <xiaolei.wang@windriver.com>
To: wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [net PATCH] net: fec: free fec queue when fec_enet_mii_init() fails
Date: Wed, 22 May 2024 10:13:17 +0800 [thread overview]
Message-ID: <20240522021317.1113689-1-xiaolei.wang@windriver.com> (raw)
commit 63e3cc2b87c2 ("arm64: dts: imx93-11x11-evk: add
reset gpios for ethernet PHYs") the rese-gpios attribute
is added, but this pcal6524 is loaded later, which causes
fec driver defer, the following memory leak occurs.
unreferenced object 0xffffff8010350000 (size 8192):
comm "kworker/u8:3", pid 39, jiffies 4294893562
hex dump (first 32 bytes):
02 00 00 00 00 00 00 00 00 50 06 8a c0 ff ff ff .........P......
e0 6f 06 8a c0 ff ff ff 00 50 06 8a c0 ff ff ff .o.......P......
backtrace (crc f1b8b79f):
[<0000000057d2c6ae>] kmemleak_alloc+0x34/0x40
[<000000003c413e60>] kmalloc_trace+0x2f8/0x460
[<00000000663f64e6>] fec_probe+0x1364/0x3a04
[<0000000024d7e427>] platform_probe+0xc4/0x198
[<00000000293aa124>] really_probe+0x17c/0x4f0
[<00000000dfd1e0f3>] __driver_probe_device+0x158/0x2c4
[<000000004ae0034a>] driver_probe_device+0x60/0x18c
[<00000000fa3ad0e1>] __device_attach_driver+0x168/0x208
[<00000000394a38d3>] bus_for_each_drv+0x104/0x190
[<00000000c44e3dea>] __device_attach+0x1f8/0x33c
[<000000004db69c14>] device_initial_probe+0x14/0x20
[<00000000f4705309>] bus_probe_device+0x128/0x158
[<00000000f7115919>] deferred_probe_work_func+0x12c/0x1d8
[<0000000012315b3b>] process_scheduled_works+0x6c0/0x164c
[<0000000089b2b6e1>] worker_thread+0x370/0x95c
[<000000004dbe3d1a>] kthread+0x360/0x420
Fixes: 63e3cc2b87c2 ("arm64: dts: imx93-11x11-evk: add reset gpios for ethernet PHYs")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index a72d8a2eb0b3..2b3534d434d8 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4524,6 +4524,7 @@ fec_probe(struct platform_device *pdev)
fec_enet_mii_remove(fep);
failed_mii_init:
failed_irq:
+ fec_enet_free_queue(ndev);
failed_init:
fec_ptp_stop(pdev);
failed_reset:
--
2.25.1
next reply other threads:[~2024-05-22 2:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 2:13 Xiaolei Wang [this message]
2024-05-22 3:04 ` [net PATCH] net: fec: free fec queue when fec_enet_mii_init() fails Wei Fang
2024-05-22 3:14 ` Andrew Lunn
2024-05-22 7:28 ` Wei Fang
2024-05-22 23:23 ` wang xiaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522021317.1113689-1-xiaolei.wang@windriver.com \
--to=xiaolei.wang@windriver.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox