From: Andrew Lunn <andrew@lunn.ch>
To: Wei Fang <wei.fang@nxp.com>
Cc: Xiaolei Wang <xiaolei.wang@windriver.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [net PATCH] net: fec: free fec queue when fec_enet_mii_init() fails
Date: Wed, 22 May 2024 05:14:41 +0200 [thread overview]
Message-ID: <8bbf2c1d-5083-4321-bded-f83aba5428fa@lunn.ch> (raw)
In-Reply-To: <PAXPR04MB8510B1D6C8B77D7E154CC6CF88EB2@PAXPR04MB8510.eurprd04.prod.outlook.com>
> The commit 59d0f7465644 ("net: fec: init multi queue date structure")
> was the first to introduce this issue, commit 619fee9eb13b
> ("net: fec: fix the potential memory leak in fec_enet_init() ")
> fixed this, but it does not seem to be completely fixed.
This fix is also not great, and i would say the initial design is
really the problem. There needs to be a function which is the opposite
of fec_enet_init(). It can then be called in the probe cleanup code,
and in fec_drv_remove() which also appears to leak the queues.
Andrew
next prev parent reply other threads:[~2024-05-22 3:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 2:13 [net PATCH] net: fec: free fec queue when fec_enet_mii_init() fails Xiaolei Wang
2024-05-22 3:04 ` Wei Fang
2024-05-22 3:14 ` Andrew Lunn [this message]
2024-05-22 7:28 ` Wei Fang
2024-05-22 23:23 ` wang xiaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bbf2c1d-5083-4321-bded-f83aba5428fa@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaolei.wang@windriver.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox