* [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic
@ 2024-07-01 19:57 Frank Li
2024-07-08 14:57 ` Rob Herring (Arm)
2024-07-10 10:15 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2024-07-01 19:57 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
always true.
if:
properties:
compatible:
contains:
enum:
- fsl,ls1021a-qdma
Change to check other compatible strings to get correct logic and fix
below CHECK_DTB warnings.
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb:
dma-controller@8380000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- Change maxItems: 5 to minItems: 5. because maxItems: 5 already restrict
at top
interrupts:
minItems: 2
maxItems: 5
---
Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
index 25e410a149fce..9401b1f6300d4 100644
--- a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
@@ -92,8 +92,16 @@ allOf:
compatible:
contains:
enum:
- - fsl,ls1021a-qdma
+ - fsl,ls1028a-qdma
+ - fsl,ls1043a-qdma
+ - fsl,ls1046a-qdma
then:
+ properties:
+ interrupts:
+ minItems: 5
+ interrupt-names:
+ minItems: 5
+ else:
properties:
interrupts:
maxItems: 3
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic
2024-07-01 19:57 [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic Frank Li
@ 2024-07-08 14:57 ` Rob Herring (Arm)
2024-07-10 10:15 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-07-08 14:57 UTC (permalink / raw)
To: Frank Li
Cc: Conor Dooley, devicetree, Vinod Koul, imx, linux-kernel,
Krzysztof Kozlowski, dmaengine
On Mon, 01 Jul 2024 15:57:16 -0400, Frank Li wrote:
> All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
> always true.
>
> if:
> properties:
> compatible:
> contains:
> enum:
> - fsl,ls1021a-qdma
>
> Change to check other compatible strings to get correct logic and fix
> below CHECK_DTB warnings.
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb:
> dma-controller@8380000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - Change maxItems: 5 to minItems: 5. because maxItems: 5 already restrict
> at top
>
> interrupts:
> minItems: 2
> maxItems: 5
> ---
> Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic
2024-07-01 19:57 [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic Frank Li
2024-07-08 14:57 ` Rob Herring (Arm)
@ 2024-07-10 10:15 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-07-10 10:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, dmaengine,
devicetree, linux-kernel, Frank Li
Cc: imx
On Mon, 01 Jul 2024 15:57:16 -0400, Frank Li wrote:
> All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
> always true.
>
> if:
> properties:
> compatible:
> contains:
> enum:
> - fsl,ls1021a-qdma
>
> [...]
Applied, thanks!
[1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic
commit: b8ec9dba02a74797421c52b1226b23a4302362a6
Best regards,
--
Vinod Koul <vkoul@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-10 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 19:57 [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic Frank Li
2024-07-08 14:57 ` Rob Herring (Arm)
2024-07-10 10:15 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox