* [PATCH 2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION
2024-10-15 7:29 [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency Arnd Bergmann
@ 2024-10-15 7:29 ` Arnd Bergmann
2024-10-18 16:05 ` Dmitry Baryshkov
2024-10-18 16:05 ` [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency Dmitry Baryshkov
2024-10-22 13:50 ` Robert Foss
2 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2024-10-15 7:29 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Shawn Guo, Sascha Hauer, Dmitry Baryshkov,
Philipp Zabel
Cc: Arnd Bergmann, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Pengutronix Kernel Team, Fabio Estevam, dri-devel, imx,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Every module should have a description, without this we get a
build time warning.
Fixes: cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings DT node")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
index 07a78a02a884..3ebf0b9866de 100644
--- a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
+++ b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c
@@ -85,3 +85,4 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct device *dev,
EXPORT_SYMBOL_GPL(devm_imx_drm_legacy_bridge);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Freescale i.MX DRM bridge driver for legacy DT bindings");
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION
2024-10-15 7:29 ` [PATCH 2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION Arnd Bergmann
@ 2024-10-18 16:05 ` Dmitry Baryshkov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-10-18 16:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Shawn Guo, Sascha Hauer, Philipp Zabel,
Arnd Bergmann, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Pengutronix Kernel Team, Fabio Estevam, dri-devel, imx,
linux-arm-kernel, linux-kernel
On Tue, Oct 15, 2024 at 07:29:58AM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Every module should have a description, without this we get a
> build time warning.
>
> Fixes: cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings DT node")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency
2024-10-15 7:29 [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency Arnd Bergmann
2024-10-15 7:29 ` [PATCH 2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION Arnd Bergmann
@ 2024-10-18 16:05 ` Dmitry Baryshkov
2024-10-22 13:50 ` Robert Foss
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-10-18 16:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Shawn Guo,
Sascha Hauer, Arnd Bergmann, Pengutronix Kernel Team,
Fabio Estevam, Alexander Stein, Geert Uytterhoeven, dri-devel,
imx, linux-arm-kernel, linux-kernel
On Tue, Oct 15, 2024 at 07:29:57AM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver now uses the legacy bridge helper code but can be configured
> to get built without it:
>
> ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!
>
> Add the required dependency, same as in the ldb driver.
>
> Fixes: f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/imx/ipuv3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency
2024-10-15 7:29 [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency Arnd Bergmann
2024-10-15 7:29 ` [PATCH 2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION Arnd Bergmann
2024-10-18 16:05 ` [PATCH 1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency Dmitry Baryshkov
@ 2024-10-22 13:50 ` Robert Foss
2 siblings, 0 replies; 5+ messages in thread
From: Robert Foss @ 2024-10-22 13:50 UTC (permalink / raw)
To: Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Shawn Guo,
Sascha Hauer, Dmitry Baryshkov, Arnd Bergmann
Cc: Arnd Bergmann, Pengutronix Kernel Team, Fabio Estevam,
Alexander Stein, Geert Uytterhoeven, dri-devel, imx,
linux-arm-kernel, linux-kernel
On Tue, 15 Oct 2024 07:29:57 +0000, Arnd Bergmann wrote:
> The driver now uses the legacy bridge helper code but can be configured
> to get built without it:
>
> ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!
>
> Add the required dependency, same as in the ldb driver.
>
> [...]
Applied, thanks!
[1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/ef214002e6b3
[2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/df606be44c16
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread