From: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@nxp.com>,
Larisa Grigore <larisa.grigore@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lee Jones <lee@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>, Jacky Bai <ping.bai@nxp.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP S32 Linux Team <s32@nxp.com>,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
imx@lists.linux.dev,
Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
Subject: [PATCH v6 0/7] gpio: siul2-s32g2: add initial GPIO driver
Date: Wed, 13 Nov 2024 12:10:52 +0200 [thread overview]
Message-ID: <20241113101124.1279648-1-andrei.stefanescu@oss.nxp.com> (raw)
This patch series adds support for basic GPIO
operations(set, get, direction_output/input, set_config).
There are two SIUL2 hardware modules: SIUL2_0 and SIUL2_1.
However, this driver exports both as a single GPIO driver.
This is because the interrupt registers are located only
in SIUL2_1, even for GPIOs that are part of SIUL2_0.
There are two gaps in the GPIO ranges:
- 102-111(inclusive) are invalid
- 123-143(inclusive) are invalid
These will be excluded via the `gpio-reserved-ranges`
property.
Writing and reading GPIO values is done via the PGPDO/PGPDI
registers(Parallel GPIO Pad Data Output/Input) which are
16 bit registers, each bit corresponding to a GPIO.
Note that the PGPDO order is similar to a big-endian grouping
of two registers:
PGPDO1, PGPDO0, PGPDO3, PGPDO2, PGPDO5, PGPDO4, gap, PGPDO6.
I have other patches for this driver:
- interrupt support
- power management callbacks
which I plan to upstream after this series gets merged
in order to simplify the review process.
v6 -> v5
- removed description for reg in the dt-bindings and added
maxItems
- dropped label for example in the dt-bindings
- simplified the example in the dt-bindings
- changed dt-bindings filename to nxp,s32g2-siul2.yaml
- changed title in the dt-bindings
- dropped minItmes from gpio-ranges/gpio-reserved-ranges
and added maxItems to gpio-reserved-ranges
- added required block for -grp[0-9]$ nodes
- switch to using "" as quotes
- kernel test robot: fixed frame sizes, added description
for reg_name, fixed typo in gpio_configs_lock, removed
uninitialized ret variable usage
- ordered includes in nxp-siul2.c, switched to dev-err-probe
added a mention that other commits will add nvmem functionality
to the mfd driver
- switched spin_lock_irqsave to scoped_guard statement
- switched dev_err to dev_err_probe in pinctrl-s32cc in places
reached during the probing part
v5 -> v4
- fixed di_div error
- fixed dt-bindings error
- added Co-developed-by tags
- added new MFD driver nxp-siul2.c
- made the old pinctrl driver an MFD cell
- added the GPIO driver in the existing SIUL2 pinctrl one
- Switch from "devm_pinctrl_register" to
"devm_pinctrl_register_and_init"
v4 -> v3
- removed useless parentheses
- added S32G3 fallback compatible
- fixed comment alignment
- fixed dt-bindings license
- fixed modpost: "__udivdi3"
- moved MAINTAINERS entry to have the new GPIO driver
together with other files related to S32G
v3 -> v2
- fix dt-bindings schema id
- add maxItems to gpio-ranges
- removed gpio label from dt-bindings example
- added changelog for the MAINTAINERS commit and
added separate entry for the SIUL2 GPIO driver
- added guard(raw_spinlock_irqsave) in
'siul2_gpio_set_direction'
- updated the description for
'devm_platform_get_and_ioremap_resource_byname'
v2 -> v1
dt-bindings:
- changed filename to match compatible
- fixed commit messages
- removed dt-bindings unnecessary properties descriptions
- added minItems for the interrupts property
driver:
- added depends on ARCH_S32 || COMPILE_TEST to Kconfig
- added select REGMAP_MMIO to Kconfig
- remove unnecessary include
- add of_node_put after `siul2_get_gpio_pinspec`
- removed inline from function definitions
- removed match data and moved the previous platdata
definition to the top of the file to be visible
- replace bitmap_set/clear with __clear_bit/set_bit
and devm_bitmap_zalloc with devm_kzalloc
- switched to gpiochip_generic_request/free/config
- fixed dev_err format for size_t reported by
kernel test robot
- add platform_get_and_ioremap_resource_byname wrapper
Andrei Stefanescu (7):
dt-bindings: mfd: add support for the NXP SIUL2 module
mfd: nxp-siul2: add support for NXP SIUL2
arm64: dts: s32g: make pinctrl part of mfd node
pinctrl: s32: convert the driver into an mfd cell
pinctrl: s32cc: change to "devm_pinctrl_register_and_init"
pinctrl: s32cc: implement GPIO functionality
MAINTAINERS: add MAINTAINER for NXP SIUL2 MFD driver
.../bindings/mfd/nxp,s32g2-siul2.yaml | 165 +++++
MAINTAINERS | 2 +
arch/arm64/boot/dts/freescale/s32g2.dtsi | 26 +-
arch/arm64/boot/dts/freescale/s32g3.dtsi | 26 +-
drivers/mfd/Kconfig | 12 +
drivers/mfd/Makefile | 1 +
drivers/mfd/nxp-siul2.c | 410 +++++++++++++
drivers/pinctrl/nxp/pinctrl-s32.h | 3 +-
drivers/pinctrl/nxp/pinctrl-s32cc.c | 564 +++++++++++++-----
drivers/pinctrl/nxp/pinctrl-s32g2.c | 25 +-
include/linux/mfd/nxp-siul2.h | 55 ++
11 files changed, 1089 insertions(+), 200 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/nxp,s32g2-siul2.yaml
create mode 100644 drivers/mfd/nxp-siul2.c
create mode 100644 include/linux/mfd/nxp-siul2.h
--
2.45.2
next reply other threads:[~2024-11-13 10:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 10:10 Andrei Stefanescu [this message]
2024-11-13 10:10 ` [PATCH v6 1/7] dt-bindings: mfd: add support for the NXP SIUL2 module Andrei Stefanescu
2024-11-13 15:26 ` Frank Li
2024-11-19 9:21 ` Krzysztof Kozlowski
2024-11-19 9:44 ` Andrei Stefanescu
2024-11-19 13:12 ` Krzysztof Kozlowski
2024-11-20 9:21 ` Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 2/7] mfd: nxp-siul2: add support for NXP SIUL2 Andrei Stefanescu
2024-12-11 12:45 ` Lee Jones
2024-12-11 15:44 ` Mark Brown
2024-12-13 17:15 ` Lee Jones
2024-12-20 13:16 ` Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 3/7] arm64: dts: s32g: make pinctrl part of mfd node Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 4/7] pinctrl: s32: convert the driver into an mfd cell Andrei Stefanescu
2024-11-19 9:26 ` Krzysztof Kozlowski
2024-11-19 9:57 ` Andrei Stefanescu
2024-11-19 13:51 ` Krzysztof Kozlowski
2024-11-20 9:29 ` Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 5/7] pinctrl: s32cc: change to "devm_pinctrl_register_and_init" Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 6/7] pinctrl: s32cc: implement GPIO functionality Andrei Stefanescu
2024-12-11 17:02 ` Markus Elfring
2024-11-13 10:10 ` [PATCH v6 7/7] MAINTAINERS: add MAINTAINER for NXP SIUL2 MFD driver Andrei Stefanescu
2024-11-13 14:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113101124.1279648-1-andrei.stefanescu@oss.nxp.com \
--to=andrei.stefanescu@oss.nxp.com \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=aruizrui@redhat.com \
--cc=brgl@bgdev.pl \
--cc=chester62515@gmail.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=ping.bai@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox