From: Markus Elfring <Markus.Elfring@web.de>
To: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
s32@nxp.com, Bartosz Golaszewski <brgl@bgdev.pl>,
Chester Lin <chester62515@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jacky Bai <ping.bai@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Larisa Grigore <larisa.grigore@nxp.com>,
Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <mbrugger@suse.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, Alberto Ruiz <aruizrui@redhat.com>,
Christophe Lizzi <clizzi@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH v6 6/7] pinctrl: s32cc: implement GPIO functionality
Date: Wed, 11 Dec 2024 18:02:46 +0100 [thread overview]
Message-ID: <384bdbaf-15f1-4cad-8f77-371ccb67d952@web.de> (raw)
In-Reply-To: <20241113101124.1279648-7-andrei.stefanescu@oss.nxp.com>
…
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
…
> +static void s32_gpio_free(struct gpio_chip *gc, unsigned int gpio)
> +{
…
> + spin_lock_irqsave(&ipctl->gpio_configs_lock, flags);
> +
> + list_for_each_entry_safe(gpio_pin, tmp, &ipctl->gpio_configs, list) {
…
> + }
> +
> +unlock:
> + spin_unlock_irqrestore(&ipctl->gpio_configs_lock, flags);
> +}
How do you think about to apply another call “scoped_guard(spinlock_irqsave, &ipctl->gpio_configs_lock)” here?
Regards,
Markus
next prev parent reply other threads:[~2024-12-11 17:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 10:10 [PATCH v6 0/7] gpio: siul2-s32g2: add initial GPIO driver Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 1/7] dt-bindings: mfd: add support for the NXP SIUL2 module Andrei Stefanescu
2024-11-13 15:26 ` Frank Li
2024-11-19 9:21 ` Krzysztof Kozlowski
2024-11-19 9:44 ` Andrei Stefanescu
2024-11-19 13:12 ` Krzysztof Kozlowski
2024-11-20 9:21 ` Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 2/7] mfd: nxp-siul2: add support for NXP SIUL2 Andrei Stefanescu
2024-12-11 12:45 ` Lee Jones
2024-12-11 15:44 ` Mark Brown
2024-12-13 17:15 ` Lee Jones
2024-12-20 13:16 ` Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 3/7] arm64: dts: s32g: make pinctrl part of mfd node Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 4/7] pinctrl: s32: convert the driver into an mfd cell Andrei Stefanescu
2024-11-19 9:26 ` Krzysztof Kozlowski
2024-11-19 9:57 ` Andrei Stefanescu
2024-11-19 13:51 ` Krzysztof Kozlowski
2024-11-20 9:29 ` Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 5/7] pinctrl: s32cc: change to "devm_pinctrl_register_and_init" Andrei Stefanescu
2024-11-13 10:10 ` [PATCH v6 6/7] pinctrl: s32cc: implement GPIO functionality Andrei Stefanescu
2024-12-11 17:02 ` Markus Elfring [this message]
2024-11-13 10:10 ` [PATCH v6 7/7] MAINTAINERS: add MAINTAINER for NXP SIUL2 MFD driver Andrei Stefanescu
2024-11-13 14:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384bdbaf-15f1-4cad-8f77-371ccb67d952@web.de \
--to=markus.elfring@web.de \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andrei.stefanescu@oss.nxp.com \
--cc=aruizrui@redhat.com \
--cc=brgl@bgdev.pl \
--cc=chester62515@gmail.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=ping.bai@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox