Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
* [PATCH] drm/imx: dc: Sort bits and bitfields in descending order
@ 2025-10-14 11:41 Marek Vasut
  2025-10-14 15:34 ` Frank Li
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2025-10-14 11:41 UTC (permalink / raw)
  To: dri-devel
  Cc: Marek Vasut, David Airlie, Fabio Estevam, Liu Ying,
	Maarten Lankhorst, Maxime Ripard, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Simona Vetter, Thomas Zimmermann, imx,
	linux-arm-kernel, linux-kernel

Consistently sort bits and bitfields from highest to lowest bits.
No functional change.

Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: David Airlie <airlied@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/gpu/drm/imx/dc/dc-ed.c |  8 ++++----
 drivers/gpu/drm/imx/dc/dc-fg.c |  4 ++--
 drivers/gpu/drm/imx/dc/dc-fu.c | 10 +++++-----
 drivers/gpu/drm/imx/dc/dc-fu.h |  4 ++--
 drivers/gpu/drm/imx/dc/dc-lb.c | 28 ++++++++++++++--------------
 5 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/gpu/drm/imx/dc/dc-ed.c b/drivers/gpu/drm/imx/dc/dc-ed.c
index 86ecc22d0a554..d42f33d6f3fcc 100644
--- a/drivers/gpu/drm/imx/dc/dc-ed.c
+++ b/drivers/gpu/drm/imx/dc/dc-ed.c
@@ -15,12 +15,12 @@
 #include "dc-pe.h"
 
 #define PIXENGCFG_STATIC	0x8
-#define  POWERDOWN		BIT(4)
-#define  SYNC_MODE		BIT(8)
-#define  SINGLE			0
 #define  DIV_MASK		GENMASK(23, 16)
 #define  DIV(x)			FIELD_PREP(DIV_MASK, (x))
 #define  DIV_RESET		0x80
+#define  SYNC_MODE		BIT(8)
+#define  SINGLE			0
+#define  POWERDOWN		BIT(4)
 
 #define PIXENGCFG_DYNAMIC	0xc
 
@@ -28,9 +28,9 @@
 #define  SYNC_TRIGGER		BIT(0)
 
 #define STATICCONTROL		0x8
+#define  PERFCOUNTMODE		BIT(12)
 #define  KICK_MODE		BIT(8)
 #define  EXTERNAL		BIT(8)
-#define  PERFCOUNTMODE		BIT(12)
 
 #define CONTROL			0xc
 #define  GAMMAAPPLYENABLE	BIT(0)
diff --git a/drivers/gpu/drm/imx/dc/dc-fg.c b/drivers/gpu/drm/imx/dc/dc-fg.c
index 7f6c1852bf724..28f372be92472 100644
--- a/drivers/gpu/drm/imx/dc/dc-fg.c
+++ b/drivers/gpu/drm/imx/dc/dc-fg.c
@@ -56,9 +56,9 @@
 
 #define FGINCTRL		0x5c
 #define FGINCTRLPANIC		0x60
-#define  FGDM_MASK		GENMASK(2, 0)
-#define  ENPRIMALPHA		BIT(3)
 #define  ENSECALPHA		BIT(4)
+#define  ENPRIMALPHA		BIT(3)
+#define  FGDM_MASK		GENMASK(2, 0)
 
 #define FGCCR			0x64
 #define  CCGREEN(x)		FIELD_PREP(GENMASK(19, 10), (x))
diff --git a/drivers/gpu/drm/imx/dc/dc-fu.c b/drivers/gpu/drm/imx/dc/dc-fu.c
index f94c591c81589..1d8f74babef8a 100644
--- a/drivers/gpu/drm/imx/dc/dc-fu.c
+++ b/drivers/gpu/drm/imx/dc/dc-fu.c
@@ -18,11 +18,11 @@
 #define BASEADDRESSAUTOUPDATE(x)	FIELD_PREP(BASEADDRESSAUTOUPDATE_MASK, (x))
 
 /* BURSTBUFFERMANAGEMENT */
+#define LINEMODE_MASK			BIT(31)
 #define SETBURSTLENGTH_MASK		GENMASK(12, 8)
 #define SETBURSTLENGTH(x)		FIELD_PREP(SETBURSTLENGTH_MASK, (x))
 #define SETNUMBUFFERS_MASK		GENMASK(7, 0)
 #define SETNUMBUFFERS(x)		FIELD_PREP(SETNUMBUFFERS_MASK, (x))
-#define LINEMODE_MASK			BIT(31)
 
 /* SOURCEBUFFERATTRIBUTES */
 #define BITSPERPIXEL_MASK		GENMASK(21, 16)
@@ -31,20 +31,20 @@
 #define STRIDE(x)			FIELD_PREP(STRIDE_MASK, (x) - 1)
 
 /* SOURCEBUFFERDIMENSION */
-#define LINEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
 #define LINECOUNT(x)			FIELD_PREP(GENMASK(29, 16), (x))
+#define LINEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
 
 /* LAYEROFFSET */
-#define LAYERXOFFSET(x)			FIELD_PREP(GENMASK(14, 0), (x))
 #define LAYERYOFFSET(x)			FIELD_PREP(GENMASK(30, 16), (x))
+#define LAYERXOFFSET(x)			FIELD_PREP(GENMASK(14, 0), (x))
 
 /* CLIPWINDOWOFFSET */
-#define CLIPWINDOWXOFFSET(x)		FIELD_PREP(GENMASK(14, 0), (x))
 #define CLIPWINDOWYOFFSET(x)		FIELD_PREP(GENMASK(30, 16), (x))
+#define CLIPWINDOWXOFFSET(x)		FIELD_PREP(GENMASK(14, 0), (x))
 
 /* CLIPWINDOWDIMENSIONS */
-#define CLIPWINDOWWIDTH(x)		FIELD_PREP(GENMASK(13, 0), (x) - 1)
 #define CLIPWINDOWHEIGHT(x)		FIELD_PREP(GENMASK(29, 16), (x) - 1)
+#define CLIPWINDOWWIDTH(x)		FIELD_PREP(GENMASK(13, 0), (x) - 1)
 
 enum dc_linemode {
 	/*
diff --git a/drivers/gpu/drm/imx/dc/dc-fu.h b/drivers/gpu/drm/imx/dc/dc-fu.h
index e016e1ea5b4e0..f678de3ca8c0a 100644
--- a/drivers/gpu/drm/imx/dc/dc-fu.h
+++ b/drivers/gpu/drm/imx/dc/dc-fu.h
@@ -33,13 +33,13 @@
 #define A_SHIFT(x)			FIELD_PREP_CONST(GENMASK(4, 0), (x))
 
 /* LAYERPROPERTY */
+#define SOURCEBUFFERENABLE		BIT(31)
 #define YUVCONVERSIONMODE_MASK		GENMASK(18, 17)
 #define YUVCONVERSIONMODE(x)		FIELD_PREP(YUVCONVERSIONMODE_MASK, (x))
-#define SOURCEBUFFERENABLE		BIT(31)
 
 /* FRAMEDIMENSIONS */
-#define FRAMEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
 #define FRAMEHEIGHT(x)			FIELD_PREP(GENMASK(29, 16), (x))
+#define FRAMEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
 
 /* CONTROL */
 #define INPUTSELECT_MASK		GENMASK(4, 3)
diff --git a/drivers/gpu/drm/imx/dc/dc-lb.c b/drivers/gpu/drm/imx/dc/dc-lb.c
index 38f966625d382..ca1d714c8d6e6 100644
--- a/drivers/gpu/drm/imx/dc/dc-lb.c
+++ b/drivers/gpu/drm/imx/dc/dc-lb.c
@@ -17,12 +17,12 @@
 #include "dc-pe.h"
 
 #define PIXENGCFG_DYNAMIC			0x8
-#define  PIXENGCFG_DYNAMIC_PRIM_SEL_MASK	GENMASK(5, 0)
-#define  PIXENGCFG_DYNAMIC_PRIM_SEL(x)		\
-		FIELD_PREP(PIXENGCFG_DYNAMIC_PRIM_SEL_MASK, (x))
 #define  PIXENGCFG_DYNAMIC_SEC_SEL_MASK		GENMASK(13, 8)
 #define  PIXENGCFG_DYNAMIC_SEC_SEL(x)		\
 		FIELD_PREP(PIXENGCFG_DYNAMIC_SEC_SEL_MASK, (x))
+#define  PIXENGCFG_DYNAMIC_PRIM_SEL_MASK	GENMASK(5, 0)
+#define  PIXENGCFG_DYNAMIC_PRIM_SEL(x)		\
+		FIELD_PREP(PIXENGCFG_DYNAMIC_PRIM_SEL_MASK, (x))
 
 #define STATICCONTROL				0x8
 #define  SHDTOKSEL_MASK				GENMASK(4, 3)
@@ -37,24 +37,24 @@
 #define BLENDCONTROL				0x10
 #define  ALPHA_MASK				GENMASK(23, 16)
 #define  ALPHA(x)				FIELD_PREP(ALPHA_MASK, (x))
-#define  PRIM_C_BLD_FUNC_MASK			GENMASK(2, 0)
-#define  PRIM_C_BLD_FUNC(x)			\
-		FIELD_PREP(PRIM_C_BLD_FUNC_MASK, (x))
-#define  SEC_C_BLD_FUNC_MASK			GENMASK(6, 4)
-#define  SEC_C_BLD_FUNC(x)			\
-		FIELD_PREP(SEC_C_BLD_FUNC_MASK, (x))
-#define  PRIM_A_BLD_FUNC_MASK			GENMASK(10, 8)
-#define  PRIM_A_BLD_FUNC(x)			\
-		FIELD_PREP(PRIM_A_BLD_FUNC_MASK, (x))
 #define  SEC_A_BLD_FUNC_MASK			GENMASK(14, 12)
 #define  SEC_A_BLD_FUNC(x)			\
 		FIELD_PREP(SEC_A_BLD_FUNC_MASK, (x))
+#define  PRIM_A_BLD_FUNC_MASK			GENMASK(10, 8)
+#define  PRIM_A_BLD_FUNC(x)			\
+		FIELD_PREP(PRIM_A_BLD_FUNC_MASK, (x))
+#define  SEC_C_BLD_FUNC_MASK			GENMASK(6, 4)
+#define  SEC_C_BLD_FUNC(x)			\
+		FIELD_PREP(SEC_C_BLD_FUNC_MASK, (x))
+#define  PRIM_C_BLD_FUNC_MASK			GENMASK(2, 0)
+#define  PRIM_C_BLD_FUNC(x)			\
+		FIELD_PREP(PRIM_C_BLD_FUNC_MASK, (x))
 
 #define POSITION				0x14
-#define  XPOS_MASK				GENMASK(15, 0)
-#define  XPOS(x)				FIELD_PREP(XPOS_MASK, (x))
 #define  YPOS_MASK				GENMASK(31, 16)
 #define  YPOS(x)				FIELD_PREP(YPOS_MASK, (x))
+#define  XPOS_MASK				GENMASK(15, 0)
+#define  XPOS(x)				FIELD_PREP(XPOS_MASK, (x))
 
 enum dc_lb_blend_func {
 	DC_LAYERBLEND_BLEND_ZERO,
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/imx: dc: Sort bits and bitfields in descending order
  2025-10-14 11:41 [PATCH] drm/imx: dc: Sort bits and bitfields in descending order Marek Vasut
@ 2025-10-14 15:34 ` Frank Li
  2025-10-15  7:17 ` Liu Ying
  2025-10-16  3:30 ` Liu Ying
  2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-10-14 15:34 UTC (permalink / raw)
  To: Marek Vasut
  Cc: dri-devel, David Airlie, Fabio Estevam, Liu Ying,
	Maarten Lankhorst, Maxime Ripard, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Simona Vetter, Thomas Zimmermann, imx,
	linux-arm-kernel, linux-kernel

On Tue, Oct 14, 2025 at 01:41:07PM +0200, Marek Vasut wrote:
> Consistently sort bits and bitfields from highest to lowest bits.
> No functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/gpu/drm/imx/dc/dc-ed.c |  8 ++++----
>  drivers/gpu/drm/imx/dc/dc-fg.c |  4 ++--
>  drivers/gpu/drm/imx/dc/dc-fu.c | 10 +++++-----
>  drivers/gpu/drm/imx/dc/dc-fu.h |  4 ++--
>  drivers/gpu/drm/imx/dc/dc-lb.c | 28 ++++++++++++++--------------
>  5 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dc/dc-ed.c b/drivers/gpu/drm/imx/dc/dc-ed.c
> index 86ecc22d0a554..d42f33d6f3fcc 100644
> --- a/drivers/gpu/drm/imx/dc/dc-ed.c
> +++ b/drivers/gpu/drm/imx/dc/dc-ed.c
> @@ -15,12 +15,12 @@
>  #include "dc-pe.h"
>
>  #define PIXENGCFG_STATIC	0x8
> -#define  POWERDOWN		BIT(4)
> -#define  SYNC_MODE		BIT(8)
> -#define  SINGLE			0
>  #define  DIV_MASK		GENMASK(23, 16)
>  #define  DIV(x)			FIELD_PREP(DIV_MASK, (x))
>  #define  DIV_RESET		0x80
> +#define  SYNC_MODE		BIT(8)
> +#define  SINGLE			0
> +#define  POWERDOWN		BIT(4)
>
>  #define PIXENGCFG_DYNAMIC	0xc
>
> @@ -28,9 +28,9 @@
>  #define  SYNC_TRIGGER		BIT(0)
>
>  #define STATICCONTROL		0x8
> +#define  PERFCOUNTMODE		BIT(12)
>  #define  KICK_MODE		BIT(8)
>  #define  EXTERNAL		BIT(8)
> -#define  PERFCOUNTMODE		BIT(12)
>
>  #define CONTROL			0xc
>  #define  GAMMAAPPLYENABLE	BIT(0)
> diff --git a/drivers/gpu/drm/imx/dc/dc-fg.c b/drivers/gpu/drm/imx/dc/dc-fg.c
> index 7f6c1852bf724..28f372be92472 100644
> --- a/drivers/gpu/drm/imx/dc/dc-fg.c
> +++ b/drivers/gpu/drm/imx/dc/dc-fg.c
> @@ -56,9 +56,9 @@
>
>  #define FGINCTRL		0x5c
>  #define FGINCTRLPANIC		0x60
> -#define  FGDM_MASK		GENMASK(2, 0)
> -#define  ENPRIMALPHA		BIT(3)
>  #define  ENSECALPHA		BIT(4)
> +#define  ENPRIMALPHA		BIT(3)
> +#define  FGDM_MASK		GENMASK(2, 0)
>
>  #define FGCCR			0x64
>  #define  CCGREEN(x)		FIELD_PREP(GENMASK(19, 10), (x))
> diff --git a/drivers/gpu/drm/imx/dc/dc-fu.c b/drivers/gpu/drm/imx/dc/dc-fu.c
> index f94c591c81589..1d8f74babef8a 100644
> --- a/drivers/gpu/drm/imx/dc/dc-fu.c
> +++ b/drivers/gpu/drm/imx/dc/dc-fu.c
> @@ -18,11 +18,11 @@
>  #define BASEADDRESSAUTOUPDATE(x)	FIELD_PREP(BASEADDRESSAUTOUPDATE_MASK, (x))
>
>  /* BURSTBUFFERMANAGEMENT */
> +#define LINEMODE_MASK			BIT(31)
>  #define SETBURSTLENGTH_MASK		GENMASK(12, 8)
>  #define SETBURSTLENGTH(x)		FIELD_PREP(SETBURSTLENGTH_MASK, (x))
>  #define SETNUMBUFFERS_MASK		GENMASK(7, 0)
>  #define SETNUMBUFFERS(x)		FIELD_PREP(SETNUMBUFFERS_MASK, (x))
> -#define LINEMODE_MASK			BIT(31)
>
>  /* SOURCEBUFFERATTRIBUTES */
>  #define BITSPERPIXEL_MASK		GENMASK(21, 16)
> @@ -31,20 +31,20 @@
>  #define STRIDE(x)			FIELD_PREP(STRIDE_MASK, (x) - 1)
>
>  /* SOURCEBUFFERDIMENSION */
> -#define LINEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
>  #define LINECOUNT(x)			FIELD_PREP(GENMASK(29, 16), (x))
> +#define LINEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
>
>  /* LAYEROFFSET */
> -#define LAYERXOFFSET(x)			FIELD_PREP(GENMASK(14, 0), (x))
>  #define LAYERYOFFSET(x)			FIELD_PREP(GENMASK(30, 16), (x))
> +#define LAYERXOFFSET(x)			FIELD_PREP(GENMASK(14, 0), (x))
>
>  /* CLIPWINDOWOFFSET */
> -#define CLIPWINDOWXOFFSET(x)		FIELD_PREP(GENMASK(14, 0), (x))
>  #define CLIPWINDOWYOFFSET(x)		FIELD_PREP(GENMASK(30, 16), (x))
> +#define CLIPWINDOWXOFFSET(x)		FIELD_PREP(GENMASK(14, 0), (x))
>
>  /* CLIPWINDOWDIMENSIONS */
> -#define CLIPWINDOWWIDTH(x)		FIELD_PREP(GENMASK(13, 0), (x) - 1)
>  #define CLIPWINDOWHEIGHT(x)		FIELD_PREP(GENMASK(29, 16), (x) - 1)
> +#define CLIPWINDOWWIDTH(x)		FIELD_PREP(GENMASK(13, 0), (x) - 1)
>
>  enum dc_linemode {
>  	/*
> diff --git a/drivers/gpu/drm/imx/dc/dc-fu.h b/drivers/gpu/drm/imx/dc/dc-fu.h
> index e016e1ea5b4e0..f678de3ca8c0a 100644
> --- a/drivers/gpu/drm/imx/dc/dc-fu.h
> +++ b/drivers/gpu/drm/imx/dc/dc-fu.h
> @@ -33,13 +33,13 @@
>  #define A_SHIFT(x)			FIELD_PREP_CONST(GENMASK(4, 0), (x))
>
>  /* LAYERPROPERTY */
> +#define SOURCEBUFFERENABLE		BIT(31)
>  #define YUVCONVERSIONMODE_MASK		GENMASK(18, 17)
>  #define YUVCONVERSIONMODE(x)		FIELD_PREP(YUVCONVERSIONMODE_MASK, (x))
> -#define SOURCEBUFFERENABLE		BIT(31)
>
>  /* FRAMEDIMENSIONS */
> -#define FRAMEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
>  #define FRAMEHEIGHT(x)			FIELD_PREP(GENMASK(29, 16), (x))
> +#define FRAMEWIDTH(x)			FIELD_PREP(GENMASK(13, 0), (x))
>
>  /* CONTROL */
>  #define INPUTSELECT_MASK		GENMASK(4, 3)
> diff --git a/drivers/gpu/drm/imx/dc/dc-lb.c b/drivers/gpu/drm/imx/dc/dc-lb.c
> index 38f966625d382..ca1d714c8d6e6 100644
> --- a/drivers/gpu/drm/imx/dc/dc-lb.c
> +++ b/drivers/gpu/drm/imx/dc/dc-lb.c
> @@ -17,12 +17,12 @@
>  #include "dc-pe.h"
>
>  #define PIXENGCFG_DYNAMIC			0x8
> -#define  PIXENGCFG_DYNAMIC_PRIM_SEL_MASK	GENMASK(5, 0)
> -#define  PIXENGCFG_DYNAMIC_PRIM_SEL(x)		\
> -		FIELD_PREP(PIXENGCFG_DYNAMIC_PRIM_SEL_MASK, (x))
>  #define  PIXENGCFG_DYNAMIC_SEC_SEL_MASK		GENMASK(13, 8)
>  #define  PIXENGCFG_DYNAMIC_SEC_SEL(x)		\
>  		FIELD_PREP(PIXENGCFG_DYNAMIC_SEC_SEL_MASK, (x))
> +#define  PIXENGCFG_DYNAMIC_PRIM_SEL_MASK	GENMASK(5, 0)
> +#define  PIXENGCFG_DYNAMIC_PRIM_SEL(x)		\
> +		FIELD_PREP(PIXENGCFG_DYNAMIC_PRIM_SEL_MASK, (x))
>
>  #define STATICCONTROL				0x8
>  #define  SHDTOKSEL_MASK				GENMASK(4, 3)
> @@ -37,24 +37,24 @@
>  #define BLENDCONTROL				0x10
>  #define  ALPHA_MASK				GENMASK(23, 16)
>  #define  ALPHA(x)				FIELD_PREP(ALPHA_MASK, (x))
> -#define  PRIM_C_BLD_FUNC_MASK			GENMASK(2, 0)
> -#define  PRIM_C_BLD_FUNC(x)			\
> -		FIELD_PREP(PRIM_C_BLD_FUNC_MASK, (x))
> -#define  SEC_C_BLD_FUNC_MASK			GENMASK(6, 4)
> -#define  SEC_C_BLD_FUNC(x)			\
> -		FIELD_PREP(SEC_C_BLD_FUNC_MASK, (x))
> -#define  PRIM_A_BLD_FUNC_MASK			GENMASK(10, 8)
> -#define  PRIM_A_BLD_FUNC(x)			\
> -		FIELD_PREP(PRIM_A_BLD_FUNC_MASK, (x))
>  #define  SEC_A_BLD_FUNC_MASK			GENMASK(14, 12)
>  #define  SEC_A_BLD_FUNC(x)			\
>  		FIELD_PREP(SEC_A_BLD_FUNC_MASK, (x))
> +#define  PRIM_A_BLD_FUNC_MASK			GENMASK(10, 8)
> +#define  PRIM_A_BLD_FUNC(x)			\
> +		FIELD_PREP(PRIM_A_BLD_FUNC_MASK, (x))
> +#define  SEC_C_BLD_FUNC_MASK			GENMASK(6, 4)
> +#define  SEC_C_BLD_FUNC(x)			\
> +		FIELD_PREP(SEC_C_BLD_FUNC_MASK, (x))
> +#define  PRIM_C_BLD_FUNC_MASK			GENMASK(2, 0)
> +#define  PRIM_C_BLD_FUNC(x)			\
> +		FIELD_PREP(PRIM_C_BLD_FUNC_MASK, (x))
>
>  #define POSITION				0x14
> -#define  XPOS_MASK				GENMASK(15, 0)
> -#define  XPOS(x)				FIELD_PREP(XPOS_MASK, (x))
>  #define  YPOS_MASK				GENMASK(31, 16)
>  #define  YPOS(x)				FIELD_PREP(YPOS_MASK, (x))
> +#define  XPOS_MASK				GENMASK(15, 0)
> +#define  XPOS(x)				FIELD_PREP(XPOS_MASK, (x))
>
>  enum dc_lb_blend_func {
>  	DC_LAYERBLEND_BLEND_ZERO,
> --
> 2.51.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/imx: dc: Sort bits and bitfields in descending order
  2025-10-14 11:41 [PATCH] drm/imx: dc: Sort bits and bitfields in descending order Marek Vasut
  2025-10-14 15:34 ` Frank Li
@ 2025-10-15  7:17 ` Liu Ying
  2025-10-16  3:30 ` Liu Ying
  2 siblings, 0 replies; 4+ messages in thread
From: Liu Ying @ 2025-10-15  7:17 UTC (permalink / raw)
  To: Marek Vasut, dri-devel
  Cc: David Airlie, Fabio Estevam, Maarten Lankhorst, Maxime Ripard,
	Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Simona Vetter,
	Thomas Zimmermann, imx, linux-arm-kernel, linux-kernel

On 10/14/2025, Marek Vasut wrote:
> Consistently sort bits and bitfields from highest to lowest bits.
> No functional change.
> 
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/gpu/drm/imx/dc/dc-ed.c |  8 ++++----
>  drivers/gpu/drm/imx/dc/dc-fg.c |  4 ++--
>  drivers/gpu/drm/imx/dc/dc-fu.c | 10 +++++-----
>  drivers/gpu/drm/imx/dc/dc-fu.h |  4 ++--
>  drivers/gpu/drm/imx/dc/dc-lb.c | 28 ++++++++++++++--------------
>  5 files changed, 27 insertions(+), 27 deletions(-)

Reviewed-by: Liu Ying <victor.liu@nxp.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/imx: dc: Sort bits and bitfields in descending order
  2025-10-14 11:41 [PATCH] drm/imx: dc: Sort bits and bitfields in descending order Marek Vasut
  2025-10-14 15:34 ` Frank Li
  2025-10-15  7:17 ` Liu Ying
@ 2025-10-16  3:30 ` Liu Ying
  2 siblings, 0 replies; 4+ messages in thread
From: Liu Ying @ 2025-10-16  3:30 UTC (permalink / raw)
  To: Marek Vasut, dri-devel
  Cc: David Airlie, Fabio Estevam, Maarten Lankhorst, Maxime Ripard,
	Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Simona Vetter,
	Thomas Zimmermann, imx, linux-arm-kernel, linux-kernel

On 10/14/2025, Marek Vasut wrote:
> Consistently sort bits and bitfields from highest to lowest bits.
> No functional change.
> 
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/gpu/drm/imx/dc/dc-ed.c |  8 ++++----
>  drivers/gpu/drm/imx/dc/dc-fg.c |  4 ++--
>  drivers/gpu/drm/imx/dc/dc-fu.c | 10 +++++-----
>  drivers/gpu/drm/imx/dc/dc-fu.h |  4 ++--
>  drivers/gpu/drm/imx/dc/dc-lb.c | 28 ++++++++++++++--------------
>  5 files changed, 27 insertions(+), 27 deletions(-)

Applied to misc/kernel.git (drm-misc-next).  Thanks!

-- 
Regards,
Liu Ying

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-10-16  3:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 11:41 [PATCH] drm/imx: dc: Sort bits and bitfields in descending order Marek Vasut
2025-10-14 15:34 ` Frank Li
2025-10-15  7:17 ` Liu Ying
2025-10-16  3:30 ` Liu Ying

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox