Re: [PATCH v2 1/1] media: dt-bindings: video-interfaces: add video-interfaces.h information

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Frank,

Thank you for the patch.

On Tue, Oct 21, 2025 at 11:49:22AM -0400, Frank Li wrote:
> Mention include/dt-bindings/media/video-interfaces.h in descriptions to
> help avoid use hardcode in dts.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> changes in v2
> - update commit message "mention ..."
> - use full path include/dt-bindings/media/video-interfaces.h
> ---
>  Documentation/devicetree/bindings/media/video-interfaces.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> index 038e85b45befa..6ed4695cacf7e 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> @@ -95,7 +95,7 @@ properties:
>        - 6 # BT.656
>        - 7 # DPI

I wondered if we should reference the macros here as well:

    enum:
      - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
      - 2 # MEDIA_BUS_TYPE_CSI1
      - 3 # MEDIA_BUS_TYPE_CCP2
      - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
      - 5 # MEDIA_BUS_TYPE_PARALLEL
      - 6 # MEDIA_BUS_TYPE_BT656
      - 7 # DPI

(Annoyingly we don't have a macro for DPI.)

This can be done separately if desired, so

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>      description:
> -      Data bus type.
> +      Data bus type. See include/dt-bindings/media/video-interfaces.h.
>  
>    bus-width:
>      $ref: /schemas/types.yaml#/definitions/uint32
> @@ -229,7 +229,7 @@ properties:
>        Imaging. The length of the array must be the same length as the
>        data-lanes property. If the line-orders property is omitted, the value
>        shall be interpreted as 0 (ABC). This property is valid for CSI-2 C-PHY
> -      busses only.
> +      busses only. See include/dt-bindings/media/video-interfaces.h.
>  
>    strobe:
>      $ref: /schemas/types.yaml#/definitions/uint32

-- 
Regards,

Laurent Pinchart