From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 4/6] dmaengine: imx-sdma: use common config at dma_chan
Date: Wed, 14 Jan 2026 12:12:45 -0500 [thread overview]
Message-ID: <20260114-dma_common_config-v1-4-64feb836ff04@nxp.com> (raw)
In-Reply-To: <20260114-dma_common_config-v1-0-64feb836ff04@nxp.com>
Use common config at dma_chan. No functional change.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/dma/imx-sdma.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index ed9e56de5a9b9484c6598d438f66a836504818be..13a9522eb914bd7808a079fd661d99e8fcff6a0b 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -413,7 +413,6 @@ struct sdma_desc {
* @sdma: pointer to the SDMA engine for this channel
* @channel: the channel number, matches dmaengine chan_id + 1
* @direction: transfer type. Needed for setting SDMA script
- * @slave_config: Slave configuration
* @peripheral_type: Peripheral type. Needed for setting SDMA script
* @event_id0: aka dma request line
* @event_id1: for channels that use 2 events
@@ -449,7 +448,6 @@ struct sdma_channel {
struct sdma_engine *sdma;
unsigned int channel;
enum dma_transfer_direction direction;
- struct dma_slave_config slave_config;
enum sdma_peripheral_type peripheral_type;
unsigned int event_id0;
unsigned int event_id1;
@@ -1647,7 +1645,7 @@ static struct dma_async_tx_descriptor *sdma_prep_slave_sg(
struct scatterlist *sg;
struct sdma_desc *desc;
- sdma_config_write(chan, &sdmac->slave_config, direction);
+ sdma_config_write(chan, &chan->config, direction);
desc = sdma_transfer_init(sdmac, direction, sg_len);
if (!desc)
@@ -1739,7 +1737,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
if (sdmac->peripheral_type != IMX_DMATYPE_HDMI)
num_periods = buf_len / period_len;
- sdma_config_write(chan, &sdmac->slave_config, direction);
+ sdma_config_write(chan, &chan->config, direction);
desc = sdma_transfer_init(sdmac, direction, num_periods);
if (!desc)
@@ -1838,8 +1836,6 @@ static int sdma_config(struct dma_chan *chan,
struct sdma_channel *sdmac = to_sdma_chan(chan);
struct sdma_engine *sdma = sdmac->sdma;
- memcpy(&sdmac->slave_config, dmaengine_cfg, sizeof(*dmaengine_cfg));
-
if (dmaengine_cfg->peripheral_config) {
struct sdma_peripheral_config *sdmacfg = dmaengine_cfg->peripheral_config;
if (dmaengine_cfg->peripheral_size != sizeof(struct sdma_peripheral_config)) {
--
2.34.1
next prev parent reply other threads:[~2026-01-14 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 17:12 [PATCH 0/6] dmaengine: Add common dma_slave_config and split it into src and dst parts Frank Li
2026-01-14 17:12 ` [PATCH 1/6] dmaengine: Move struct dma_chan after struct dma_slave_config Frank Li
2026-01-14 17:12 ` [PATCH 2/6] dmaengine: Add common slave configuration to dma_chan Frank Li
2026-01-14 17:12 ` [PATCH 3/6] dmaengine: fsl-edma: use dma_chan common config Frank Li
2026-01-14 17:12 ` Frank Li [this message]
2026-01-14 17:12 ` [PATCH 5/6] dmaengine: Add union and dma_slave_get_config() helper for dma_slave_config Frank Li
2026-01-14 17:12 ` [PATCH 6/6] dmaengine: fsl-edma: use common dma_slave_get_cfg() Frank Li
2026-03-09 11:24 ` [PATCH 0/6] dmaengine: Add common dma_slave_config and split it into src and dst parts Vinod Koul
2026-03-09 14:27 ` Frank Li
2026-03-17 10:26 ` Vinod Koul
2026-03-17 13:56 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114-dma_common_config-v1-4-64feb836ff04@nxp.com \
--to=frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox