From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 5/6] dmaengine: Add union and dma_slave_get_config() helper for dma_slave_config
Date: Wed, 14 Jan 2026 12:12:46 -0500 [thread overview]
Message-ID: <20260114-dma_common_config-v1-5-64feb836ff04@nxp.com> (raw)
In-Reply-To: <20260114-dma_common_config-v1-0-64feb836ff04@nxp.com>
Previously, src_ and dst_ prefixes were used to distinguish address,
addr_width, maxburst, and port_window_size fields. This required drivers
to add conditional logic based on transfer direction.
Introduce struct dma_slave_cfg to group these fields and add the
dma_slave_get_config() helper to retrieve the source or destination
configuration based on the DMA transfer direction. This reduces
direction-based branching in drivers and improves readability.
Use a union to preserve the old field naming and maintain compatibility.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
include/linux/dmaengine.h | 42 ++++++++++++++++++++++++++++++++++--------
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 362a43c3e36e232b5a65ff78ba0b692c0401e50c..03632bccc7ccb3c0c4a9c78f15865f35a375836a 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -384,21 +384,47 @@ enum dma_slave_buswidth {
* If not: if it is fixed so that it be sent in static from the platform
* data, then prefer to do that.
*/
+struct dma_slave_cfg { /* order must be align below dma_slave_config union */
+ phys_addr_t addr;
+ enum dma_slave_buswidth addr_width;
+ u32 maxburst;
+ u32 port_window_size;
+};
+
struct dma_slave_config {
enum dma_transfer_direction direction;
- phys_addr_t src_addr;
- phys_addr_t dst_addr;
- enum dma_slave_buswidth src_addr_width;
- enum dma_slave_buswidth dst_addr_width;
- u32 src_maxburst;
- u32 dst_maxburst;
- u32 src_port_window_size;
- u32 dst_port_window_size;
+ union {
+ struct {
+ phys_addr_t src_addr;
+ enum dma_slave_buswidth src_addr_width;
+ u32 src_maxburst;
+ u32 src_port_window_size;
+ phys_addr_t dst_addr;
+ enum dma_slave_buswidth dst_addr_width;
+ u32 dst_maxburst;
+ u32 dst_port_window_size;
+ };
+
+ struct {
+ struct dma_slave_cfg src;
+ struct dma_slave_cfg dst;
+ };
+ };
bool device_fc;
void *peripheral_config;
size_t peripheral_size;
};
+static inline struct dma_slave_cfg *
+dma_slave_get_cfg(struct dma_slave_config *config,
+ enum dma_transfer_direction dir)
+{
+ if (dir == DMA_MEM_TO_DEV)
+ return &config->dst;
+
+ return &config->src;
+}
+
/**
* struct dma_chan - devices supply DMA channels, clients use them
* @device: ptr to the dma device who supplies this channel, always !%NULL
--
2.34.1
next prev parent reply other threads:[~2026-01-14 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 17:12 [PATCH 0/6] dmaengine: Add common dma_slave_config and split it into src and dst parts Frank Li
2026-01-14 17:12 ` [PATCH 1/6] dmaengine: Move struct dma_chan after struct dma_slave_config Frank Li
2026-01-14 17:12 ` [PATCH 2/6] dmaengine: Add common slave configuration to dma_chan Frank Li
2026-01-14 17:12 ` [PATCH 3/6] dmaengine: fsl-edma: use dma_chan common config Frank Li
2026-01-14 17:12 ` [PATCH 4/6] dmaengine: imx-sdma: use common config at dma_chan Frank Li
2026-01-14 17:12 ` Frank Li [this message]
2026-01-14 17:12 ` [PATCH 6/6] dmaengine: fsl-edma: use common dma_slave_get_cfg() Frank Li
2026-03-09 11:24 ` [PATCH 0/6] dmaengine: Add common dma_slave_config and split it into src and dst parts Vinod Koul
2026-03-09 14:27 ` Frank Li
2026-03-17 10:26 ` Vinod Koul
2026-03-17 13:56 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114-dma_common_config-v1-5-64feb836ff04@nxp.com \
--to=frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox