Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
* [PATCH 1/2] usb: dwc3: add '*'  for @needs_full_reinit comment
@ 2026-03-03  2:15 Xu Yang
  2026-03-03  2:15 ` [PATCH 2/2] usb: dwc3: fix a typo Xu Yang
  2026-03-03 15:49 ` [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Frank Li
  0 siblings, 2 replies; 6+ messages in thread
From: Xu Yang @ 2026-03-03  2:15 UTC (permalink / raw)
  To: Thinh.Nguyen, gregkh; +Cc: linux-usb, imx, linux-kernel

Fix a comment codestyle of needs_full_reinit.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
 drivers/usb/dwc3/core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 67bcc8dccc89..7adb8e74bd84 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1120,7 +1120,7 @@ struct dwc3_glue_ops {
  * @usb2_lpm_disable: set to disable usb2 lpm for host
  * @usb2_gadget_lpm_disable: set to disable usb2 lpm for gadget
  * @needs_full_reinit: set to indicate the core may lose power and need full
-			initialization during system pm
+ *			initialization during system pm
  * @disable_scramble_quirk: set if we enable the disable scramble quirk
  * @u2exit_lfps_quirk: set if we enable u2exit lfps quirk
  * @u2ss_inp3_quirk: set if we enable P3 OK for U2/SS Inactive quirk
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] usb: dwc3: fix a typo
  2026-03-03  2:15 [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Xu Yang
@ 2026-03-03  2:15 ` Xu Yang
  2026-03-03 15:48   ` Frank Li
  2026-03-03 15:49 ` [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Frank Li
  1 sibling, 1 reply; 6+ messages in thread
From: Xu Yang @ 2026-03-03  2:15 UTC (permalink / raw)
  To: Thinh.Nguyen, gregkh; +Cc: linux-usb, imx, linux-kernel

HishSpeed -> HighSpeed

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
 drivers/usb/dwc3/core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 7adb8e74bd84..41cfefb34abd 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1151,7 +1151,7 @@ struct dwc3_glue_ops {
  *			VBUS with an external supply.
  * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
  *			instances in park mode.
- * @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
+ * @parkmode_disable_hs_quirk: set if we need to disable all HighSpeed
  *			instances in park mode.
  * @gfladj_refclk_lpm_sel: set if we need to enable SOF/ITP counter
  *                          running based on ref_clk
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] usb: dwc3: fix a typo
  2026-03-03  2:15 ` [PATCH 2/2] usb: dwc3: fix a typo Xu Yang
@ 2026-03-03 15:48   ` Frank Li
  2026-03-03 23:53     ` Thinh Nguyen
  0 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2026-03-03 15:48 UTC (permalink / raw)
  To: Xu Yang; +Cc: Thinh.Nguyen, gregkh, linux-usb, imx, linux-kernel

On Tue, Mar 03, 2026 at 10:15:59AM +0800, Xu Yang wrote:
> HishSpeed -> HighSpeed

subject: usb: dwc3: fix a typo 'HishSpeed'

Frank
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  drivers/usb/dwc3/core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 7adb8e74bd84..41cfefb34abd 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1151,7 +1151,7 @@ struct dwc3_glue_ops {
>   *			VBUS with an external supply.
>   * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
>   *			instances in park mode.
> - * @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed
> + * @parkmode_disable_hs_quirk: set if we need to disable all HighSpeed
>   *			instances in park mode.
>   * @gfladj_refclk_lpm_sel: set if we need to enable SOF/ITP counter
>   *                          running based on ref_clk
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] usb: dwc3: add '*'  for @needs_full_reinit comment
  2026-03-03  2:15 [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Xu Yang
  2026-03-03  2:15 ` [PATCH 2/2] usb: dwc3: fix a typo Xu Yang
@ 2026-03-03 15:49 ` Frank Li
  2026-03-03 23:54   ` Thinh Nguyen
  1 sibling, 1 reply; 6+ messages in thread
From: Frank Li @ 2026-03-03 15:49 UTC (permalink / raw)
  To: Xu Yang; +Cc: Thinh.Nguyen, gregkh, linux-usb, imx, linux-kernel

On Tue, Mar 03, 2026 at 10:15:58AM +0800, Xu Yang wrote:
> Fix a comment codestyle of needs_full_reinit.

Fix kernel-doc issue?

Frank

>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  drivers/usb/dwc3/core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 67bcc8dccc89..7adb8e74bd84 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1120,7 +1120,7 @@ struct dwc3_glue_ops {
>   * @usb2_lpm_disable: set to disable usb2 lpm for host
>   * @usb2_gadget_lpm_disable: set to disable usb2 lpm for gadget
>   * @needs_full_reinit: set to indicate the core may lose power and need full
> -			initialization during system pm
> + *			initialization during system pm
>   * @disable_scramble_quirk: set if we enable the disable scramble quirk
>   * @u2exit_lfps_quirk: set if we enable u2exit lfps quirk
>   * @u2ss_inp3_quirk: set if we enable P3 OK for U2/SS Inactive quirk
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] usb: dwc3: fix a typo
  2026-03-03 15:48   ` Frank Li
@ 2026-03-03 23:53     ` Thinh Nguyen
  0 siblings, 0 replies; 6+ messages in thread
From: Thinh Nguyen @ 2026-03-03 23:53 UTC (permalink / raw)
  To: Frank Li
  Cc: Xu Yang, Thinh Nguyen, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org

On Tue, Mar 03, 2026, Frank Li wrote:
> On Tue, Mar 03, 2026 at 10:15:59AM +0800, Xu Yang wrote:
> > HishSpeed -> HighSpeed
> 
> subject: usb: dwc3: fix a typo 'HishSpeed'
> 

I know it's trivial, but please write a full sentence/paragraph in the
body describing the fix.

Also, please add Fixes tag.

Thanks,
Thinh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] usb: dwc3: add '*'  for @needs_full_reinit comment
  2026-03-03 15:49 ` [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Frank Li
@ 2026-03-03 23:54   ` Thinh Nguyen
  0 siblings, 0 replies; 6+ messages in thread
From: Thinh Nguyen @ 2026-03-03 23:54 UTC (permalink / raw)
  To: Frank Li
  Cc: Xu Yang, Thinh Nguyen, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org

On Tue, Mar 03, 2026, Frank Li wrote:
> On Tue, Mar 03, 2026 at 10:15:58AM +0800, Xu Yang wrote:
> > Fix a comment codestyle of needs_full_reinit.
> 
> Fix kernel-doc issue?
> 
> 

Also, add Fixes tag.

Thanks,
Thinh

> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> >  drivers/usb/dwc3/core.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> > index 67bcc8dccc89..7adb8e74bd84 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -1120,7 +1120,7 @@ struct dwc3_glue_ops {
> >   * @usb2_lpm_disable: set to disable usb2 lpm for host
> >   * @usb2_gadget_lpm_disable: set to disable usb2 lpm for gadget
> >   * @needs_full_reinit: set to indicate the core may lose power and need full
> > -			initialization during system pm
> > + *			initialization during system pm
> >   * @disable_scramble_quirk: set if we enable the disable scramble quirk
> >   * @u2exit_lfps_quirk: set if we enable u2exit lfps quirk
> >   * @u2ss_inp3_quirk: set if we enable P3 OK for U2/SS Inactive quirk
> > --
> > 2.34.1
> >

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-03 23:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03  2:15 [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Xu Yang
2026-03-03  2:15 ` [PATCH 2/2] usb: dwc3: fix a typo Xu Yang
2026-03-03 15:48   ` Frank Li
2026-03-03 23:53     ` Thinh Nguyen
2026-03-03 15:49 ` [PATCH 1/2] usb: dwc3: add '*' for @needs_full_reinit comment Frank Li
2026-03-03 23:54   ` Thinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox