* [PATCH] usb: dwc3: imx: avoid calling imx suspend/resume callbacks twice
@ 2026-03-17 3:05 Xu Yang
2026-03-18 1:18 ` Thinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Xu Yang @ 2026-03-17 3:05 UTC (permalink / raw)
To: Thinh.Nguyen, gregkh, Frank.Li, s.hauer, kernel, festevam
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel, jun.li
If a runtime suspend is executed followed by a system suspend, the driver
may invoke dwc3_imx_suspend() twice, which causes enable_irq() to be
called twice as well. This leads to an unbalanced IRQ state and may
trigger warnings or malfunction. Prevent this by checking the pm_suspended
flag before running the imx suspend/resume path.
Fixes: 76fc9452a6bf ("usb: dwc3: introduce flatten model driver of i.MX Soc")
Cc: stable@vger.kernel.org
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
drivers/usb/dwc3/dwc3-imx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c
index 303708f7d79a..973a486b544d 100644
--- a/drivers/usb/dwc3/dwc3-imx.c
+++ b/drivers/usb/dwc3/dwc3-imx.c
@@ -288,6 +288,9 @@ static void dwc3_imx_remove(struct platform_device *pdev)
static void dwc3_imx_suspend(struct dwc3_imx *dwc_imx, pm_message_t msg)
{
+ if (dwc_imx->pm_suspended)
+ return;
+
if (PMSG_IS_AUTO(msg) || device_may_wakeup(dwc_imx->dev))
dwc3_imx_wakeup_enable(dwc_imx, msg);
@@ -299,6 +302,9 @@ static void dwc3_imx_resume(struct dwc3_imx *dwc_imx, pm_message_t msg)
{
struct dwc3 *dwc = &dwc_imx->dwc;
+ if (!dwc_imx->pm_suspended)
+ return;
+
dwc_imx->pm_suspended = false;
if (!dwc_imx->wakeup_pending)
disable_irq_nosync(dwc_imx->irq);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: imx: avoid calling imx suspend/resume callbacks twice
2026-03-17 3:05 [PATCH] usb: dwc3: imx: avoid calling imx suspend/resume callbacks twice Xu Yang
@ 2026-03-18 1:18 ` Thinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Thinh Nguyen @ 2026-03-18 1:18 UTC (permalink / raw)
To: Xu Yang
Cc: Thinh Nguyen, gregkh@linuxfoundation.org, Frank.Li@nxp.com,
s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
linux-usb@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jun.li@nxp.com
On Tue, Mar 17, 2026, Xu Yang wrote:
> If a runtime suspend is executed followed by a system suspend, the driver
> may invoke dwc3_imx_suspend() twice, which causes enable_irq() to be
> called twice as well. This leads to an unbalanced IRQ state and may
> trigger warnings or malfunction. Prevent this by checking the pm_suspended
> flag before running the imx suspend/resume path.
>
> Fixes: 76fc9452a6bf ("usb: dwc3: introduce flatten model driver of i.MX Soc")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> drivers/usb/dwc3/dwc3-imx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c
> index 303708f7d79a..973a486b544d 100644
> --- a/drivers/usb/dwc3/dwc3-imx.c
> +++ b/drivers/usb/dwc3/dwc3-imx.c
> @@ -288,6 +288,9 @@ static void dwc3_imx_remove(struct platform_device *pdev)
>
> static void dwc3_imx_suspend(struct dwc3_imx *dwc_imx, pm_message_t msg)
> {
> + if (dwc_imx->pm_suspended)
> + return;
> +
> if (PMSG_IS_AUTO(msg) || device_may_wakeup(dwc_imx->dev))
> dwc3_imx_wakeup_enable(dwc_imx, msg);
>
> @@ -299,6 +302,9 @@ static void dwc3_imx_resume(struct dwc3_imx *dwc_imx, pm_message_t msg)
> {
> struct dwc3 *dwc = &dwc_imx->dwc;
>
> + if (!dwc_imx->pm_suspended)
> + return;
> +
> dwc_imx->pm_suspended = false;
> if (!dwc_imx->wakeup_pending)
> disable_irq_nosync(dwc_imx->irq);
> --
> 2.34.1
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
BR,
Thinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-18 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 3:05 [PATCH] usb: dwc3: imx: avoid calling imx suspend/resume callbacks twice Xu Yang
2026-03-18 1:18 ` Thinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox