Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
* [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties
@ 2026-05-09  1:54 Sherry Sun
  2026-05-09  1:54 ` [PATCH 1/3] arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties Sherry Sun
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Sherry Sun @ 2026-05-09  1:54 UTC (permalink / raw)
  To: Frank.Li, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt,
	hongxing.zhu, shawnguo
  Cc: imx, linux-arm-kernel, devicetree, linux-kernel

This series fixes PCIe endpoint mode vpcie-supply properties across
multiple i.MX platforms.

For PCIe endpoint mode, the vpcie-supply should either control the
actual M.2 power supply or be omitted if the power is always on and
uncontrollable.

Current issues:
- imx8dxl-evk and imx8qxp-mek: vpcie-supply references regulators that
  only control W_DISABLE1# signal, not actual power (which is always on)
- imx95-19x19-evk: vpcie-supply references wrong regulator (W_DISABLE1#
  instead of actual M.2 power)

So remove unnecessary properties for imx8dxl-evk and imx8qxp-mek, also
fix vpcie-supply to use correct regulator on imx95-19x19-evk.

Sherry Sun (3):
  arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties
  arm64: dts: imx8qxp-mek: Remove unnecessary PCIe EP vpcie-supply
  arm64: dts: imx95-19x19-evk: Fix PCIe EP vpcie-supply

 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts     | 2 --
 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts     | 1 -
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 2 +-
 3 files changed, 1 insertion(+), 4 deletions(-)


base-commit: 5f9e9f83aee0fa8f2124c6f192505de2cdf7c5dc
-- 
2.37.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties
  2026-05-09  1:54 [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Sherry Sun
@ 2026-05-09  1:54 ` Sherry Sun
  2026-05-09  1:54 ` [PATCH 2/3] arm64: dts: imx8qxp-mek: Remove unnecessary PCIe EP vpcie-supply Sherry Sun
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Sherry Sun @ 2026-05-09  1:54 UTC (permalink / raw)
  To: Frank.Li, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt,
	hongxing.zhu, shawnguo
  Cc: imx, linux-arm-kernel, devicetree, linux-kernel

For PCIe endpoint mode, only M.2 power supply needs to be ensured.
On imx8dxl-evk, the M.2 power is always on and cannot be controlled,
while reg_pcieb only controls the M.2 W_DISABLE1# signal. Remove the
unnecessary vpcie-supply property from pcie0_ep node.

Also remove reset-gpio as PCIe endpoint mode doesn't require reset
control.

Fixes: c1c4820b60d7 ("arm64: dts: imx8dxl-evk: Add pcie0-ep node and use unified pcie0 label")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
index bc62ae5ca812..441e00903029 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
@@ -686,8 +686,6 @@ &pcie0_ep {
 	phy-names = "pcie-phy";
 	pinctrl-0 = <&pinctrl_pcieb>;
 	pinctrl-names = "default";
-	reset-gpio = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
-	vpcie-supply = <&reg_pcieb>;
 	status = "disabled";
 };
 
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] arm64: dts: imx8qxp-mek: Remove unnecessary PCIe EP vpcie-supply
  2026-05-09  1:54 [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Sherry Sun
  2026-05-09  1:54 ` [PATCH 1/3] arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties Sherry Sun
@ 2026-05-09  1:54 ` Sherry Sun
  2026-05-09  1:54 ` [PATCH 3/3] arm64: dts: imx95-19x19-evk: Fix " Sherry Sun
  2026-05-09  2:37 ` [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Hongxing Zhu
  3 siblings, 0 replies; 5+ messages in thread
From: Sherry Sun @ 2026-05-09  1:54 UTC (permalink / raw)
  To: Frank.Li, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt,
	hongxing.zhu, shawnguo
  Cc: imx, linux-arm-kernel, devicetree, linux-kernel

For PCIe endpoint mode, only M.2 power supply needs to be ensured.
On imx8qxp-mek, the M.2 power is always on and cannot be controlled,
while reg_pcieb only controls the M.2 W_DISABLE1# signal. Remove the
unnecessary vpcie-supply property from pcie0_ep node.

Fixes: 1c9b0c6044c2 ("arm64: dts: imx8: use common imx-pcie0-ep.dtso to enable PCI ep function")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 623169f7ddb5..c07138055229 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -742,7 +742,6 @@ &pcie0_ep {
 	phy-names = "pcie-phy";
 	pinctrl-0 = <&pinctrl_pcieb>;
 	pinctrl-names = "default";
-	vpcie-supply = <&reg_pcieb>;
 	status = "disabled";
 };
 
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] arm64: dts: imx95-19x19-evk: Fix PCIe EP vpcie-supply
  2026-05-09  1:54 [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Sherry Sun
  2026-05-09  1:54 ` [PATCH 1/3] arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties Sherry Sun
  2026-05-09  1:54 ` [PATCH 2/3] arm64: dts: imx8qxp-mek: Remove unnecessary PCIe EP vpcie-supply Sherry Sun
@ 2026-05-09  1:54 ` Sherry Sun
  2026-05-09  2:37 ` [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Hongxing Zhu
  3 siblings, 0 replies; 5+ messages in thread
From: Sherry Sun @ 2026-05-09  1:54 UTC (permalink / raw)
  To: Frank.Li, s.hauer, kernel, festevam, robh, krzk+dt, conor+dt,
	hongxing.zhu, shawnguo
  Cc: imx, linux-arm-kernel, devicetree, linux-kernel

The vpcie-supply property should reference the regulator that controls
the actual M.2 power supply, not the W_DISABLE1# signal.
On imx95-19x19-evk:
- reg_pcie0 controls M.2 W_DISABLE1# signal
- reg_m2_pwr controls the actual M.2 power supply

Fix the vpcie-supply to use reg_m2_pwr for proper power control in
PCIe endpoint mode.

Fixes: 58bea81052d0 ("arm64: dts: imx95: add pcie1 ep overlay file and create pcie-ep dtb files")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
index 041fd838fabb..49400bc9ba91 100644
--- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
@@ -550,7 +550,7 @@ &pcie0 {
 &pcie0_ep {
 	pinctrl-0 = <&pinctrl_pcie0>;
 	pinctrl-names = "default";
-	vpcie-supply = <&reg_pcie0>;
+	vpcie-supply = <&reg_m2_pwr>;
 	status = "disabled";
 };
 
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties
  2026-05-09  1:54 [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Sherry Sun
                   ` (2 preceding siblings ...)
  2026-05-09  1:54 ` [PATCH 3/3] arm64: dts: imx95-19x19-evk: Fix " Sherry Sun
@ 2026-05-09  2:37 ` Hongxing Zhu
  3 siblings, 0 replies; 5+ messages in thread
From: Hongxing Zhu @ 2026-05-09  2:37 UTC (permalink / raw)
  To: Sherry Sun, Frank Li, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org
  Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sherry Sun <sherry.sun@nxp.com>
> Sent: Saturday, May 9, 2026 9:54 AM
> To: Frank Li <frank.li@nxp.com>; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; Hongxing Zhu
> <hongxing.zhu@nxp.com>; shawnguo@kernel.org
> Cc: imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties
> 
> This series fixes PCIe endpoint mode vpcie-supply properties across multiple i.MX
> platforms.
> 
> For PCIe endpoint mode, the vpcie-supply should either control the actual M.2
> power supply or be omitted if the power is always on and uncontrollable.
> 
> Current issues:
> - imx8dxl-evk and imx8qxp-mek: vpcie-supply references regulators that
>   only control W_DISABLE1# signal, not actual power (which is always on)
> - imx95-19x19-evk: vpcie-supply references wrong regulator (W_DISABLE1#
>   instead of actual M.2 power)
> 
> So remove unnecessary properties for imx8dxl-evk and imx8qxp-mek, also fix
> vpcie-supply to use correct regulator on imx95-19x19-evk.
> 
> Sherry Sun (3):
>   arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties
>   arm64: dts: imx8qxp-mek: Remove unnecessary PCIe EP vpcie-supply
>   arm64: dts: imx95-19x19-evk: Fix PCIe EP vpcie-supply
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu

> 
>  arch/arm64/boot/dts/freescale/imx8dxl-evk.dts     | 2 --
>  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts     | 1 -
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 2 +-
>  3 files changed, 1 insertion(+), 4 deletions(-)
> 
> 
> base-commit: 5f9e9f83aee0fa8f2124c6f192505de2cdf7c5dc
> --
> 2.37.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-09  2:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-09  1:54 [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Sherry Sun
2026-05-09  1:54 ` [PATCH 1/3] arm64: dts: imx8dxl-evk: Remove unnecessary PCIe EP properties Sherry Sun
2026-05-09  1:54 ` [PATCH 2/3] arm64: dts: imx8qxp-mek: Remove unnecessary PCIe EP vpcie-supply Sherry Sun
2026-05-09  1:54 ` [PATCH 3/3] arm64: dts: imx95-19x19-evk: Fix " Sherry Sun
2026-05-09  2:37 ` [PATCH 0/3] arm64: dts: imx: Fix PCIe EP vpcie-supply properties Hongxing Zhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox