From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: conor+dt@kernel.org, imx@lists.linux.dev, Frank.Li@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 01/11] ARM: dts: vf610m4: Remove NOMMU platform support
Date: Fri, 19 Jun 2026 15:52:29 +0000 [thread overview]
Message-ID: <20260619155229.B8AA01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260619-dts_cleanup_arm_mcore-v1-1-0101795a2662@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete removal of VF610 Cortex-M4 NOMMU platform support leaves orphaned code and configuration.
--
commit 47df1414ffdd1b53077023f0d62226535c747e2a
Author: Frank Li <Frank.Li@nxp.com>
ARM: dts: vf610m4: Remove NOMMU platform support
This commit removes the device tree files for the obsolete Vybrid M4 NOMMU
platform to reduce maintenance burden.
> Remove the obsolete support to reduce maintenance burden and simplify the
> code.
[Severity: Medium]
Since the goal is to fully remove the VF610 Cortex-M4 NOMMU platform
support, does this patch leave behind orphaned configurations and code?
There appear to be several remaining references that might need cleaning up
to completely simplify the codebase:
- The dedicated arch/arm/configs/vf610m4_defconfig file
- The fsl,vf610m4 compatible string in the vf610_dt_compat array in
arch/arm/mach-imx/mach-vf610.c
- The fsl,vf610m4 binding in Documentation/devicetree/bindings/arm/fsl.yaml
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260619-dts_cleanup_arm_mcore-v1-0-0101795a2662@nxp.com?part=1
next prev parent reply other threads:[~2026-06-19 15:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 15:40 [PATCH 00/11] ARM: NXP: Drop NOMMU platform support Frank.Li
2026-06-19 15:40 ` [PATCH 01/11] ARM: dts: vf610m4: Remove " Frank.Li
2026-06-19 15:52 ` sashiko-bot [this message]
2026-06-19 15:40 ` [PATCH 02/11] ARM: dts: imxrt1050: " Frank.Li
2026-06-19 15:41 ` [PATCH 03/11] ARM: imx: " Frank.Li
2026-06-19 15:41 ` [PATCH 04/11] clk: imx: imxrt1050: " Frank.Li
2026-06-19 15:54 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 05/11] pinctrl: freescale: IMXRT: " Frank.Li
2026-06-19 15:41 ` [PATCH 06/11] ARM: imxrt_defconfig: " Frank.Li
2026-06-19 15:55 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 07/11] ARM: dts: lpc: " Frank.Li
2026-06-19 15:50 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 08/11] ARM: mach-lpc: " Frank.Li
2026-06-19 16:00 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 09/11] ARM: configs: lpc*: " Frank.Li
2026-06-19 15:53 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 10/11] clk: nxp: lpc: " Frank.Li
2026-06-19 15:58 ` sashiko-bot
2026-06-19 15:41 ` [PATCH 11/11] pinctrl: " Frank.Li
2026-06-19 16:07 ` [PATCH 00/11] ARM: NXP: Drop " Vladimir Zapolskiy
2026-06-19 19:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619155229.B8AA01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox