From: sashiko-bot@kernel.org
To: "Khristine Andreea Barbulescu" <khristineandreea.barbulescu@oss.nxp.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev,
Frank.Li@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v12 1/6] pinctrl: s32cc: add/fix some comments
Date: Tue, 30 Jun 2026 12:59:18 +0000 [thread overview]
Message-ID: <20260630125919.840771F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260630125403.546375-2-khristineandreea.barbulescu@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the newly added documentation for `struct s32_pinctrl_context`.
--
commit 5f6126070deb7810863589eba4923acc7b178405
Author: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>
pinctrl: s32cc: add/fix some comments
This commit updates documentation and comments in the s32cc pinctrl driver.
It documents several structures including memory regions, gpio configurations,
and the main private data structure.
> diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> index 56be6e8d624e0..2a32df932d8a7 100644
> --- a/drivers/pinctrl/nxp/pinctrl-s32cc.c
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
[ ... ]
> @@ -79,20 +85,22 @@ struct gpio_pin_config {
> };
>
> /*
> - * Pad config save/restore for power suspend/resume.
> + * struct s32_pinctrl_context - pad config save/restore for suspend/resume
> + * @pads: saved values for the pards
[Severity: Low]
This isn't a bug, but is there a typo here (pards instead of pads)?
> */
> struct s32_pinctrl_context {
> unsigned int *pads;
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260630125403.546375-1-khristineandreea.barbulescu@oss.nxp.com?part=1
next prev parent reply other threads:[~2026-06-30 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 12:53 [PATCH v12 0/6] gpio: siul2-s32g2: add initial GPIO driver Khristine Andreea Barbulescu
2026-06-30 12:53 ` [PATCH v12 1/6] pinctrl: s32cc: add/fix some comments Khristine Andreea Barbulescu
2026-06-30 12:59 ` sashiko-bot [this message]
2026-06-30 15:24 ` Frank Li
2026-06-30 12:53 ` [PATCH v12 2/6] pinctrl: s32cc: remove inline specifiers Khristine Andreea Barbulescu
2026-06-30 15:22 ` Frank Li
2026-06-30 12:54 ` [PATCH v12 3/6] pinctrl: s32cc: change to "devm_pinctrl_register_and_init" Khristine Andreea Barbulescu
2026-06-30 12:54 ` [PATCH v12 4/6] dt-bindings: pinctrl: s32g2-siul2: describe GPIO and EIRQ resources Khristine Andreea Barbulescu
2026-07-01 7:47 ` Bartosz Golaszewski
2026-06-30 12:54 ` [PATCH v12 5/6] pinctrl: s32cc: implement GPIO functionality Khristine Andreea Barbulescu
2026-06-30 13:22 ` sashiko-bot
2026-07-01 7:50 ` Bartosz Golaszewski
2026-06-30 12:54 ` [PATCH v12 6/6] arm64: dts: s32g: describe GPIO and EIRQ resources in SIUL2 pinctrl node Khristine Andreea Barbulescu
2026-07-01 7:50 ` Bartosz Golaszewski
2026-07-01 10:28 ` [PATCH v12 0/6] gpio: siul2-s32g2: add initial GPIO driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630125919.840771F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=khristineandreea.barbulescu@oss.nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox