Re: [PATCH v6 1/5] dmaengine: fsl-edma: use devm_clk_get_optional() for channel clock

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a compilation failure by calling an undefined function `devm_clk_prepare_enable()`.
--

commit 36cfeebd16ae2d241bf40213a5b9272983d736d3
Author: Joy Zou <joy.zou@nxp.com>

dmaengine: fsl-edma: use devm_clk_get_optional() for channel clock
    
This commit replaces devm_clk_get_enabled() with devm_clk_get_optional()
and removes the FSL_EDMA_DRV_HAS_CHCLK flag for channel clocks. It prepares
the driver for adding channel runtime PM support.

> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 36155ab1602a9..1e864cd4c784e 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c

[ ... ]

> @@ -808,22 +807,19 @@ static int fsl_edma_probe(struct platform_device *pdev)
>  		fsl_chan->tcd = fsl_edma->membase
>  				+ i * drvdata->chreg_space_sz + drvdata->chreg_off + len;
>  		fsl_chan->mux_addr = fsl_edma->membase + drvdata->mux_off + i * drvdata->mux_skip;
> -
> -		if (drvdata->flags & FSL_EDMA_DRV_HAS_CHCLK) {
> -			snprintf(clk_name, sizeof(clk_name), "ch%02d", i);
> -			fsl_chan->clk = devm_clk_get_enabled(&pdev->dev,
> -							     (const char *)clk_name);
> -
> -			if (IS_ERR(fsl_chan->clk))
> -				return PTR_ERR(fsl_chan->clk);
> -		}
> +		snprintf(clk_name, sizeof(clk_name), "ch%02d", i);
> +		fsl_chan->clk = devm_clk_get_optional(&pdev->dev, (const char *)clk_name);
> +		if (IS_ERR(fsl_chan->clk))
> +			return PTR_ERR(fsl_chan->clk);
> +		ret = devm_clk_prepare_enable(&pdev->dev, fsl_chan->clk);
> +		if (ret)
> +			return dev_err_probe(&pdev->dev, ret, "Failed to enable clock\n");

[Severity: Low]
Will this introduce a build failure? The function devm_clk_prepare_enable()
does not appear to be defined in the Linux kernel Common Clock Framework.

I see this compilation regression was resolved later in the patch series by
commit a5800ff547600d938eb443a21684d6291b4658d1 ("dmaengine: fsl-edma: add
runtime suspend/resume support"), but could it break git bisect if this
commit is tested independently?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-b4-edma-runtime-opt-v6-0-354ff4229c00@oss.nxp.com?part=1