Re: [PATCH v6 2/5] dmaengine: fsl-edma: use devm_clk_get_optional() for DMA engine clock

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces calls to a non-existent function `devm_clk_prepare_enable()`, resulting in a build failure.
--

commit 52e4c7b7c140f88bd3ed6ad6e10c3513c2941e5c
Author: Joy Zou <joy.zou@nxp.com>

dmaengine: fsl-edma: use devm_clk_get_optional() for DMA engine clock

This commit updates the eDMA engine clock handling to treat it as optional,
removing the FSL_EDMA_DRV_HAS_DMACLK flag and replacing
devm_clk_get_enabled() with separate get and enable calls.

> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c

[ ... ]

> @@ -733,13 +733,15 @@ static int fsl_edma_probe(struct platform_device *pdev)
>  		regs = &fsl_edma->regs;
>  	}
>  
> -	if (drvdata->flags & FSL_EDMA_DRV_HAS_DMACLK) {
> -		fsl_edma->dmaclk = devm_clk_get_enabled(&pdev->dev, "dma");
> -		if (IS_ERR(fsl_edma->dmaclk))
> -			return dev_err_probe(&pdev->dev,
> -					     PTR_ERR(fsl_edma->dmaclk),
> -					     "Missing DMA block clock.\n");
> -	}
> +	fsl_edma->dmaclk = devm_clk_get_optional(&pdev->dev, "dma");
> +	if (IS_ERR(fsl_edma->dmaclk))
> +		return dev_err_probe(&pdev->dev,
> +				     PTR_ERR(fsl_edma->dmaclk),
> +				     "Failed to get/enable DMA clock.\n");
> +
> +	ret = devm_clk_prepare_enable(&pdev->dev, fsl_edma->dmaclk);

[Severity: Low]
Does this function call cause a build regression? It appears that
devm_clk_prepare_enable() is not defined in the standard clock API, which
might result in an implicit declaration error and break git bisect.

I noticed that this is resolved later in the series in commit
a5800ff547600d938eb443a21684d6291b4658d1 (dmaengine: fsl-edma: add runtime
suspend/resume support), where these undefined function calls are removed
for both the engine clock and the channel clocks.

Is it possible to reorganize the patch series so that the build does not
fail at this intermediate step?

> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "Failed to enable clock\n");
>  
>  	ret = of_property_read_variable_u32_array(np, "dma-channel-mask", chan_mask, 1, 2);
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-b4-edma-runtime-opt-v6-0-354ff4229c00@oss.nxp.com?part=2