Re: [PATCH v2 net-next 07/14] net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Adding PHY_INTERFACE_MODE_XGMII to enetc_port_has_pcs() erroneously associates a parallel interface with an internal PCS, breaking XGMII probe.
--

commit 0ce9c644ca0e73f4e3a24d681275147515f923ae
Author: Claudiu Manoil <claudiu.manoil@nxp.com>

net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

This commit separates phylink capabilities for ENETC pseudo-MACs and
standalone MACs. It restricts pseudo-MACs to internal modes and expands
standalone MACs to support additional interfaces like 10GBASER and XGMII.

[ ... ]
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c b/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c
> index 3597cb81a7ccb..6ccf9b9090549 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c
[ ... ]
> @@ -359,7 +359,9 @@ static bool enetc_port_has_pcs(struct enetc_pf *pf)
>  	return (pf->if_mode == PHY_INTERFACE_MODE_SGMII ||
>  		pf->if_mode == PHY_INTERFACE_MODE_1000BASEX ||
>  		pf->if_mode == PHY_INTERFACE_MODE_2500BASEX ||
> -		pf->if_mode == PHY_INTERFACE_MODE_USXGMII);
> +		pf->if_mode == PHY_INTERFACE_MODE_USXGMII ||
> +		pf->if_mode == PHY_INTERFACE_MODE_10GBASER ||
> +		pf->if_mode == PHY_INTERFACE_MODE_XGMII);

[Severity: High]
Does adding XGMII here cause probe failures for ENETC v4 devices?

XGMII is a direct parallel MAC-to-PHY interface that fundamentally does not
use a PCS. If enetc_port_has_pcs() returns true for XGMII, 
enetc_mdiobus_create() will attempt to create an internal PCS via 
enetc_imdio_create().

Since the ENETC v4 .create_pcs callback is NULL, enetc_imdio_create() will
unconditionally fail and return -EOPNOTSUPP, preventing initialization when
configured with phy-mode = "xgmii".

Should PHY_INTERFACE_MODE_XGMII be excluded from this check so it can bypass
PCS initialization and allow phylink to configure the link based purely on
MAC capabilities?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702025714.456233-1-wei.fang@oss.nxp.com?part=7