Re: [PATCH v2 net-next 10/14] net: enetc: refactor SI VLAN promiscuous mode configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing explicit initialization of VLAN promiscuous mode leaves hardware and software out of sync if PCI FLR fails or is bypassed.
--

commit e4ae080b51f21aa8943d5f438c5a46ac35824f4b
Author: Wei Fang <wei.fang@nxp.com>
Subject: net: enetc: refactor SI VLAN promiscuous mode configuration

This commit refactors the VLAN promiscuous mode configuration in the enetc
driver. It removes explicit initialization of VLAN promiscuous mode during
port configuration, relying instead on the PCI FLR default state, and
introduces a unified function for setting SI VLAN promiscuous mode.

> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> index db2a800a7aaf0..096ccb35508c5 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
[ ... ]
> @@ -442,10 +438,6 @@ static void enetc_configure_port(struct enetc_pf *pf)
>  	/* split up RFS entries */
>  	enetc_port_assign_rfs_entries(pf->si);
>  
> -	/* enforce VLAN promisc mode for all SIs */
> -	pf->vlan_promisc_simap = ENETC_VLAN_PROMISC_MAP_ALL;
> -	enetc_set_vlan_promisc(hw, pf->vlan_promisc_simap);
> -
>  	enetc_port_wr(hw, ENETC_PSIPMMR, 0);

[Severity: High]
Is it safe to rely solely on PCI FLR for VLAN promiscuous mode initialization
here in enetc_configure_port()?

If the PF driver is reloaded, or the kernel is warm-booted (e.g., via kexec)
and PCI FLR fails or is disabled (e.g., via pci=noflr), the hardware's VLAN
promiscuous mode register (ENETC_PSIPVMR) will retain its previous state.

If VLAN filtering was previously enabled, could the hardware silently drop
VLAN-tagged packets while the software assumes they are accepted?

Because NETIF_F_HW_VLAN_CTAG_FILTER is not enabled by default in
ndev->features, the core network stack will not invoke enetc_pf_set_features()
during registration to sync the software state with the hardware.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702025714.456233-1-wei.fang@oss.nxp.com?part=10