Re: [PATCH v3 net-next 07/14] net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Adding PHY_INTERFACE_MODE_10GBASER to `enetc_port_has_pcs()` causes ENETC v4 probe to fail because `.create_pcs` is not implemented.
--

commit 394f96d762ecbfe37dfe5cfd42c152159d4e5353
Author: Claudiu Manoil <claudiu.manoil@nxp.com>

net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

This commit differentiates phylink capabilities between ENETC pseudo-MACs and
standalone MACs. It restricts pseudo-MACs to internal mode while configuring a
wide range of speeds, and expands standalone ENETC (v4) to support 10GBASER
mode.

> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c b/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c
> index 3597cb81a7ccb..781b22198ca86 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf_common.c
> @@ -359,7 +359,8 @@ static bool enetc_port_has_pcs(struct enetc_pf *pf)
>  	return (pf->if_mode == PHY_INTERFACE_MODE_SGMII ||
>  		pf->if_mode == PHY_INTERFACE_MODE_1000BASEX ||
>  		pf->if_mode == PHY_INTERFACE_MODE_2500BASEX ||
> -		pf->if_mode == PHY_INTERFACE_MODE_USXGMII);
> +		pf->if_mode == PHY_INTERFACE_MODE_USXGMII ||
> +		pf->if_mode == PHY_INTERFACE_MODE_10GBASER);
>  }

[Severity: High]
Will adding PHY_INTERFACE_MODE_10GBASER here cause the ENETC v4 probe to fail?

If enetc_port_has_pcs() returns true for 10gbase-r, enetc_mdiobus_create()
will call enetc_imdio_create(), which does this check:

enetc_imdio_create() {
    ...
	if (!pf->ops->create_pcs) {
		dev_err(dev, "Creating PCS is not supported\n");
		return -EOPNOTSUPP;
	}
    ...
}

Since enetc4_pf_ops doesn't appear to implement .create_pcs, will device
initialization now fail entirely with -EOPNOTSUPP when configured with
the newly supported 10GBASER mode?

> @@ -400,25 +401,42 @@ int enetc_phylink_create(struct enetc_ndev_priv *priv, struct device_node *node,
[ ... ]
> +		if (!is_enetc_rev1(priv->si)) {
> +			mac_caps |= MAC_5000FD | MAC_10000FD;
> +			__set_bit(PHY_INTERFACE_MODE_10GBASER,
> +				  pf->phylink_config.supported_interfaces);
> +		}
> +
> +		phy_interface_set_rgmii(pf->phylink_config.supported_interfaces);
> +	} else {
> +		mac_caps |= MAC_10FD | MAC_100FD | MAC_1000FD | MAC_2500FD |
> +			    MAC_5000FD | MAC_10000FD | MAC_20000FD |
> +			    MAC_25000FD;
> +	}
> +
> +	pf->phylink_config.mac_capabilities = mac_caps;
>  	phylink = phylink_create(&pf->phylink_config, of_fwnode_handle(node),
>  				 pf->if_mode, ops);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703101328.550714-1-wei.fang@oss.nxp.com?part=7