From: sashiko-bot@kernel.org
To: "Alexander Stein" <alexander.stein@ew.tq-group.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, Frank.Li@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range
Date: Tue, 07 Jul 2026 09:05:24 +0000 [thread overview]
Message-ID: <20260707090526.978C01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260707085551.1683462-3-alexander.stein@ew.tq-group.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Moving the EdgeLock reserved memory region in a shared .dtsi breaks backward compatibility for 1024MB boards with older firmware.
--
--- Patch [2]: [PATCH 2/2] arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range ---
commit 48154931b16a7f9734d0f8037cf111d05d7b8120
Author: Alexander Feilke <Alexander.Feilke@ew.tq-group.com>
arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range
TQMa91 has a 512MiB RAM variant for which the edgelock memory location
exceeds the valid memory area.
> diff --git a/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi b/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
> index c99d7bc168483..a8c79731eace5 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
> @@ -33,9 +33,9 @@ linux,cma {
> };
>
> /* EdgeLock secure enclave */
> - ele_reserved: ele-reserved@a4120000 {
> + ele_reserved: ele-reserved@94120000 {
> compatible = "shared-dma-pool";
> - reg = <0 0xa4120000 0 0x100000>;
> + reg = <0 0x94120000 0 0x100000>;
[Severity: High]
Does this break backward compatibility for 1024MB boards with older firmware?
By unconditionally moving the ele-reserved node from 0xa4120000 to 0x94120000
in the shared .dtsi, Linux will no longer reserve 0xa4120000.
If an older 1024MB board runs existing firmware that still places the ELE at
0xa4120000, would Linux treat that region as normal RAM and overwrite the live
secure enclave?
Could the new address be specified in a board-specific .dts for the 512MB
variant, or could the bootloader dynamically patch the node to reflect the
actual allocation instead?
> no-map;
> };
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707085551.1683462-1-alexander.stein@ew.tq-group.com?part=2
prev parent reply other threads:[~2026-07-07 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 8:55 [PATCH 0/2] Small fixes for TQMa91xx Alexander Stein
2026-07-07 8:55 ` [PATCH 1/2] arm64: dts: imx91-tqma9131-mba91xxca: USB phy adjustments Alexander Stein
2026-07-07 8:55 ` [PATCH 2/2] arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range Alexander Stein
2026-07-07 9:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707090526.978C01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox