[PATCH 0/2] Small fixes for TQMa91xx

[PATCH 0/2] Small fixes for TQMa91xx

[Alexander Stein]

Hi,

here are two small fixes for TQMa91xx.
One adds the USB PHY settings similar to other TQ mainboards.
The other one fixes the reserved memory for EdgeLock Enclave to be suitable
for 512MiB variants as well.

Best regards,
Alexander

Alexander Feilke (1):
  arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range

Markus Niebel (1):
  arm64: dts: imx91-tqma9131-mba91xxca: USB phy adjustments

 arch/arm64/boot/dts/freescale/imx91-tqma9131-mba91xxca.dts | 4 ++++
 arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi          | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.54.0

[PATCH 1/2] arm64: dts: imx91-tqma9131-mba91xxca: USB phy adjustments

[Alexander Stein]

From: Markus Niebel <Markus.Niebel@ew.tq-group.com>

Add samsung,picophy-pre-emp-curr-control and
samsung,picophy-dc-vol-level-adjust using the same values as other
TQ-Systems GmbH mainboards.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx91-tqma9131-mba91xxca.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx91-tqma9131-mba91xxca.dts b/arch/arm64/boot/dts/freescale/imx91-tqma9131-mba91xxca.dts
index 5c430e6fca651..60d11a4573e3f 100644
--- a/arch/arm64/boot/dts/freescale/imx91-tqma9131-mba91xxca.dts
+++ b/arch/arm64/boot/dts/freescale/imx91-tqma9131-mba91xxca.dts
@@ -518,6 +518,8 @@ &usbotg1 {
 	adp-disable;
 	usb-role-switch;
 	disable-over-current;
+	samsung,picophy-pre-emp-curr-control = <3>;
+	samsung,picophy-dc-vol-level-adjust = <7>;
 	status = "okay";
 
 	port {
@@ -532,6 +534,8 @@ &usbotg2 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 	disable-over-current;
+	samsung,picophy-pre-emp-curr-control = <3>;
+	samsung,picophy-dc-vol-level-adjust = <7>;
 	status = "okay";
 
 	hub_2_0: hub@1 {
-- 
2.54.0

[PATCH 2/2] arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range

[Alexander Stein]

From: Alexander Feilke <Alexander.Feilke@ew.tq-group.com>

TQMa91 has a 512MiB RAM variant for which the edgelock memory location
exceeds the valid memory area.

Signed-off-by: Alexander Feilke <Alexander.Feilke@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi b/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
index c99d7bc168483..a8c79731eace5 100644
--- a/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
@@ -33,9 +33,9 @@ linux,cma {
 		};
 
 		/* EdgeLock secure enclave  */
-		ele_reserved: ele-reserved@a4120000 {
+		ele_reserved: ele-reserved@94120000 {
 			compatible = "shared-dma-pool";
-			reg = <0 0xa4120000 0 0x100000>;
+			reg = <0 0x94120000 0 0x100000>;
 			no-map;
 		};
 	};
-- 
2.54.0

Re: [PATCH 2/2] arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Moving the EdgeLock reserved memory region in a shared .dtsi breaks backward compatibility for 1024MB boards with older firmware.
--

--- Patch [2]: [PATCH 2/2] arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range ---
commit 48154931b16a7f9734d0f8037cf111d05d7b8120
Author: Alexander Feilke <Alexander.Feilke@ew.tq-group.com>

arm64: dts: imx91-tqma9131: move ele-reserved memory into 512MB range

TQMa91 has a 512MiB RAM variant for which the edgelock memory location
exceeds the valid memory area.

> diff --git a/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi b/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
> index c99d7bc168483..a8c79731eace5 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx91-tqma9131.dtsi
> @@ -33,9 +33,9 @@ linux,cma {
>  		};
>  
>  		/* EdgeLock secure enclave  */
> -		ele_reserved: ele-reserved@a4120000 {
> +		ele_reserved: ele-reserved@94120000 {
>  			compatible = "shared-dma-pool";
> -			reg = <0 0xa4120000 0 0x100000>;
> +			reg = <0 0x94120000 0 0x100000>;

[Severity: High]
Does this break backward compatibility for 1024MB boards with older firmware?

By unconditionally moving the ele-reserved node from 0xa4120000 to 0x94120000
in the shared .dtsi, Linux will no longer reserve 0xa4120000.

If an older 1024MB board runs existing firmware that still places the ELE at
0xa4120000, would Linux treat that region as normal RAM and overwrite the live
secure enclave?

Could the new address be specified in a board-specific .dts for the 512MB
variant, or could the bootloader dynamically patch the node to reflect the
actual allocation instead?

>  			no-map;
>  		};
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707085551.1683462-1-alexander.stein@ew.tq-group.com?part=2