Re: [PATCH 1/2] dt-bindings: soc: imx: Add fsl,eim-bus

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The updated `$nodename` regex explicitly allows `eim-bus` but mathematically fails to match the actual node name `eim-cs1` used in the device tree, resulting in a new schema validation warning instead of fixing the issue.
- [Low] The commit message incorrectly attributes the compatible string to i.MX51 variants instead of i.MX53.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: soc: imx: Add fsl,eim-bus ---
commit c123bec5543c2323c455145cf374a9559692a3a5
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: soc: imx: Add fsl,eim-bus

This commit adds the fsl,eim-bus compatible string to the fsl,spba-bus
binding to resolve schema validation warnings for legacy i.MX devices. It
also updates the nodename pattern in the schema.

> dt-bindings: soc: imx: Add fsl,eim-bus
>    
> Add the fsl,eim-bus compatible strings for i.MX51 variants.

[Severity: Low]
This isn't a bug, but is the reference to i.MX51 variants accurate in the
commit message? The CHECK_DTBS warning listed below is specifically for
imx53-ard.dtb, which suggests this compatible is actually targeting i.MX53
variants rather than i.MX51.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml b/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
> --- a/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
> +++ b/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
[ ... ]
> @@ -36,13 +37,14 @@ select:
>  
>  properties:
>    $nodename:
> -    pattern: "^((spba|emi)-bus|bus)(@[0-9a-f]+)?$"
> +    pattern: "^((spba|emi|eim)-bus|bus)(@[0-9a-f]+)?$"

[Severity: Medium]
Will this regex change successfully clear the validation warning?

The commit message states we are fixing a warning for the node
eim-cs1@f4000000. However, the updated pattern permits eim-bus but
structurally fails to match eim-cs1. Does this mean make dtbs_check
will simply evaluate the regex against the eim-cs1@f4000000 node and emit
a new schema validation warning for the nodename?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-imx53-eim-v1-0-913b4559e5b5@nxp.com?part=1