From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: Frank.Li@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus
Date: Wed, 08 Jul 2026 20:07:24 +0000 [thread overview]
Message-ID: <20260708200724.CF06B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260708-imx53-eim-v1-2-913b4559e5b5@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message and title state that the node is being renamed to 'eim-cs1-bus', but the diff actually renames it to 'eim-bus'.
--
--- Patch [2]: [PATCH 2/2] ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus ---
commit 86f73fc53c0394f0f24861992d60173147e1e27f
Author: Frank Li <Frank.Li@nxp.com>
ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus
This commit updates the node name for the EIM bus in imx53-ard.dts to fix
CHECK_DTS warnings. The schema validation requires the node name to match
specific patterns from simple-bus.yaml.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx53-ard.dts b/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
> --- a/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
> @@ -17,7 +17,7 @@ memory@70000000 {
> reg = <0x70000000 0x40000000>;
> };
>
> - eim-cs1@f4000000 {
> + eim-bus@f4000000 {
[Severity: Medium]
Does this change unintentionally drop the "cs1" identifier?
The commit message and subject line state the node is being renamed to
"eim-cs1-bus", but the diff actually renames it to "eim-bus". While this
satisfies the simple-bus regex requirement, it seems to contradict the
stated intent in the commit message.
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "fsl,eim-bus", "simple-bus";
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-imx53-eim-v1-0-913b4559e5b5@nxp.com?part=2
prev parent reply other threads:[~2026-07-08 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 20:00 [PATCH 0/2] ARM: dts: imx: clean up fsl,emi-bus related CHECK_DTBS warnings Frank.Li
2026-07-08 20:00 ` [PATCH 1/2] dt-bindings: soc: imx: Add fsl,eim-bus Frank.Li
2026-07-08 20:10 ` sashiko-bot
2026-07-08 20:00 ` [PATCH 2/2] ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus Frank.Li
2026-07-08 20:07 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708200724.CF06B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox