[PATCH 0/2] ARM: dts: imx: clean up fsl,emi-bus related CHECK_DTBS warnings

[PATCH 0/2] ARM: dts: imx: clean up fsl,emi-bus related CHECK_DTBS warnings

[Frank.Li]

i.MX2 use fsl,emi-bus. i.MX5 use fsl,eim-bus. Since it is very very old
chips. Just leave compatible string as it and allow two kinds name.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (2):
      dt-bindings: soc: imx: Add fsl,eim-bus
      ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus

 Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml | 4 +++-
 arch/arm/boot/dts/nxp/imx/imx53-ard.dts                 | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
---
base-commit: 00160c4761ba4e846e6abc8fb9dfd90a88dc94e6
change-id: 20260708-imx53-eim-0e678a55d37c

Best regards,
--  
Frank Li <Frank.Li@nxp.com>

[PATCH 1/2] dt-bindings: soc: imx: Add fsl,eim-bus

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Add the fsl,eim-bus compatible strings for i.MX51 variants.

These compatibles are only intended for existing legacy chips (more than 15
years old) and will not be used for new device trees.

Fix below CHECK_DTBS warnings
arch/arm/boot/dts/nxp/imx/imx53-ard.dtb: /eim-cs1@f4000000: failed to match any schema with compatible: ['fsl,eim-bus', 'simple-bus']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml b/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
index 4808065fc9115..5e872ddacaab0 100644
--- a/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
+++ b/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
@@ -28,6 +28,7 @@ select:
         enum:
           - fsl,aipi-bus
           - fsl,aips
+          - fsl,eim-bus
           - fsl,emi
           - fsl,emi-bus
           - fsl,spba-bus
@@ -36,13 +37,14 @@ select:
 
 properties:
   $nodename:
-    pattern: "^((spba|emi)-bus|bus)(@[0-9a-f]+)?$"
+    pattern: "^((spba|emi|eim)-bus|bus)(@[0-9a-f]+)?$"
 
   compatible:
     items:
       - enum:
           - fsl,aipi-bus
           - fsl,aips
+          - fsl,eim-bus
           - fsl,emi
           - fsl,emi-bus
           - fsl,spba-bus

-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: soc: imx: Add fsl,eim-bus

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The updated `$nodename` regex explicitly allows `eim-bus` but mathematically fails to match the actual node name `eim-cs1` used in the device tree, resulting in a new schema validation warning instead of fixing the issue.
- [Low] The commit message incorrectly attributes the compatible string to i.MX51 variants instead of i.MX53.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: soc: imx: Add fsl,eim-bus ---
commit c123bec5543c2323c455145cf374a9559692a3a5
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: soc: imx: Add fsl,eim-bus

This commit adds the fsl,eim-bus compatible string to the fsl,spba-bus
binding to resolve schema validation warnings for legacy i.MX devices. It
also updates the nodename pattern in the schema.

> dt-bindings: soc: imx: Add fsl,eim-bus
>    
> Add the fsl,eim-bus compatible strings for i.MX51 variants.

[Severity: Low]
This isn't a bug, but is the reference to i.MX51 variants accurate in the
commit message? The CHECK_DTBS warning listed below is specifically for
imx53-ard.dtb, which suggests this compatible is actually targeting i.MX53
variants rather than i.MX51.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml b/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
> --- a/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
> +++ b/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
[ ... ]
> @@ -36,13 +37,14 @@ select:
>  
>  properties:
>    $nodename:
> -    pattern: "^((spba|emi)-bus|bus)(@[0-9a-f]+)?$"
> +    pattern: "^((spba|emi|eim)-bus|bus)(@[0-9a-f]+)?$"

[Severity: Medium]
Will this regex change successfully clear the validation warning?

The commit message states we are fixing a warning for the node
eim-cs1@f4000000. However, the updated pattern permits eim-bus but
structurally fails to match eim-cs1. Does this mean make dtbs_check
will simply evaluate the regex against the eim-cs1@f4000000 node and emit
a new schema validation warning for the nodename?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-imx53-eim-v1-0-913b4559e5b5@nxp.com?part=1

[PATCH 2/2] ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Change node name eim-cs1 to eim-cs1-bus to fix below CHECK_DTS warnings:

arch/arm/boot/dts/nxp/imx/imx53-ard.dtb: eim-cs1@f4000000 (fsl,eim-bus): $nodename:0: 'eim-cs1@f4000000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
        from schema $id: http://devicetree.org/schemas/simple-bus.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx53-ard.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx53-ard.dts b/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
index e580427660b1d..c19ac3bb0a197 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
@@ -17,7 +17,7 @@ memory@70000000 {
 		reg = <0x70000000 0x40000000>;
 	};
 
-	eim-cs1@f4000000 {
+	eim-bus@f4000000 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "fsl,eim-bus", "simple-bus";

-- 
2.43.0

Re: [PATCH 2/2] ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message and title state that the node is being renamed to 'eim-cs1-bus', but the diff actually renames it to 'eim-bus'.
--

--- Patch [2]: [PATCH 2/2] ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus ---
commit 86f73fc53c0394f0f24861992d60173147e1e27f
Author: Frank Li <Frank.Li@nxp.com>
ARM: dts: imx53-ard: change node name eim-cs1 to eim-cs1-bus

This commit updates the node name for the EIM bus in imx53-ard.dts to fix
CHECK_DTS warnings. The schema validation requires the node name to match
specific patterns from simple-bus.yaml.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx53-ard.dts b/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
> --- a/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx53-ard.dts
> @@ -17,7 +17,7 @@ memory@70000000 {
>  		reg = <0x70000000 0x40000000>;
>  	};
>  
> -	eim-cs1@f4000000 {
> +	eim-bus@f4000000 {

[Severity: Medium]
Does this change unintentionally drop the "cs1" identifier? 

The commit message and subject line state the node is being renamed to
"eim-cs1-bus", but the diff actually renames it to "eim-bus". While this
satisfies the simple-bus regex requirement, it seems to contradict the
stated intent in the commit message.

>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		compatible = "fsl,eim-bus", "simple-bus";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-imx53-eim-v1-0-913b4559e5b5@nxp.com?part=2