Re: [PATCH 1/3] arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Dangling phandle reference to a board-specific label in the common `.dtsi` file.
--

--- Patch [1]: [PATCH 1/3] arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi ---
commit 75e389bfc1f27ac338bceffb58faf699a50fada0
Author: Joseph Guo <qijian.guo@nxp.com>
Subject: arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi

This commit extracts common hardware definitions from imx93-11x11-frdm.dts
into a new imx93-11x11-frdm-common.dtsi file to allow sharing with the
wireless FRDM board.

> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi
[ ... ]
> +&lpuart5 {
> +	pinctrl-0 = <&pinctrl_uart5>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	uart-has-rtscts;
> +
> +	bluetooth {
> +		compatible = "nxp,88w8987-bt";
> +		device-wakeup-gpios = <&pcal6408 3 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&pcal6524 19 GPIO_ACTIVE_LOW>;
> +		vcc-supply = <&reg_usdhc3_vmmc>;
> +	};

[Severity: Medium]
Will other boards that include this common .dtsi fail to compile?

The bluetooth node in the new common .dtsi references &reg_usdhc3_vmmc, but
the definition for this regulator was left behind in the board-specific file.

> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts
> index bd14ba28690c0..f2a31a0eacabf 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts
[ ... ]
>  	reg_usdhc3_vmmc: regulator-usdhc3 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "VPCIe_3V3";
> @@ -76,51 +19,6 @@ reg_usdhc3_vmmc: regulator-usdhc3 {
>  		enable-active-high;
>  	};

Since the reg_usdhc3_vmmc label is not defined in the common .dtsi, any other
board attempting to include the common file will hit a missing label error
during compilation.

Should this regulator definition be moved to the common file alongside the
bluetooth node, or should the vcc-supply property be set as an override in
the board-specific files instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-imx93w_frdm-v1-0-0cca6c0ba2f5@nxp.com?part=1