From: sashiko-bot@kernel.org
To: "Joseph Guo" <qijian.guo@nxp.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support
Date: Fri, 17 Jul 2026 05:25:26 +0000 [thread overview]
Message-ID: <20260717052526.7BF851F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260717-imx93w_frdm-v1-3-0cca6c0ba2f5@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The i.MX93W FRDM device tree inherits an invalid Bluetooth configuration intended for an absent M.2 module, while omitting the correct configuration for the integrated IW610 chip.
--
--- Patch [3]: [PATCH 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support ---
commit 54467df83181ba6647f33372016b6a5139213211
Author: Joseph Guo <qijian.guo@nxp.com>
arm64: dts: imx93: Add i.MX93 Wireless FRDM board support
This commit adds device tree support for the i.MX93 Wireless FRDM board.
It reuses the common FRDM device tree include but overrides specific pins
and configurations due to the hardware switch from an M.2 module to the
integrated IW610 chip.
> diff --git a/arch/arm64/boot/dts/freescale/imx93w-frdm.dts b/arch/arm64/boot/dts/freescale/imx93w-frdm.dts
> new file mode 100644
> index 0000000000000..766e942fe6638
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93w-frdm.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2026 NXP
> + */
> +
> +/dts-v1/;
> +
> +#include "imx93w.dtsi"
> +#include "imx93-11x11-frdm-common.dtsi"
[Severity: Medium]
Does this file need to explicitly disable the bluetooth node inherited from
the common dtsi file?
The imx93-11x11-frdm-common.dtsi unconditionally enables the M.2 bluetooth
node on lpuart5. Since the M.2 module is removed on the FRDM-IMX93W board,
will the kernel attempt to initialize a non-existent device and inadvertently
toggle I2C IO expander pins intended for the absent M.2 slot?
Should the lpuart5 bluetooth node be marked disabled here, and a new node
added for the correct IW610 Bluetooth interface mentioned in the commit
message?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-imx93w_frdm-v1-0-0cca6c0ba2f5@nxp.com?part=3
prev parent reply other threads:[~2026-07-17 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 5:11 [PATCH 0/3] Add i.MX93 Wireless FRDM board support Joseph Guo
2026-07-17 5:11 ` [PATCH 1/3] arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi Joseph Guo
2026-07-17 5:19 ` sashiko-bot
2026-07-17 5:11 ` [PATCH 2/3] dt-bindings: arm: fsl: Add i.MX93 Wireless FRDM board Joseph Guo
2026-07-17 9:24 ` Krzysztof Kozlowski
2026-07-17 5:11 ` [PATCH 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support Joseph Guo
2026-07-17 5:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717052526.7BF851F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=qijian.guo@nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox