From: sashiko-bot@kernel.org
To: "Joseph Guo" <qijian.guo@nxp.com>
Cc: imx@lists.linux.dev, Frank.Li@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: imx95-15x15-frdm: add boot phase properties
Date: Fri, 14 Aug 2026 06:45:13 +0000 [thread overview]
Message-ID: <20260814064514.ABD781F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260814-bootph-frdm-imx95-v1-1-c0e3f1b9d2ed@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing device tree boot phase properties on provider dependencies (`&gpio3`, `&scmi_clk`) causes early boot (SPL) failure for UART and SD/eMMC.
--
--- Patch [1]: [PATCH] arm64: dts: imx95-15x15-frdm: add boot phase properties ---
commit 9b9056eb20751b354934dfae8becee905da7d7b0
Author: Joseph Guo <qijian.guo@nxp.com>
arm64: dts: imx95-15x15-frdm: add boot phase properties
Add boot phase properties to essential resources during boot phase.
FRDM-IMX95 need UART, SD-Card, eMMC access during boot process.
> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> index 0f43e3be70589..ba17d87f197a3 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> @@ -140,6 +140,7 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> regulator-name = "VDD_SD2_3V3";
> gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> + bootph-pre-ram;
> };
[Severity: High]
Will this regulator fail to probe during early boot (SPL)?
It appears that while this regulator is marked for SPL, its provider &gpio3
lacks boot phase tags. U-Boot's SPL device tree minification tool (fdtgrep)
drops any node lacking bootph-* tags unless it is an ancestor of a tagged node,
and phandle dependencies are not automatically kept.
If &gpio3 is excluded from the SPL DTB, could this fail to acquire the
enable GPIO and break MMC power?
[ ... ]
> @@ -445,6 +446,7 @@ led_backlight1: led@1 {
> &lpuart1 {
> pinctrl-0 = <&pinctrl_uart1>;
> pinctrl-names = "default";
> + bootph-pre-ram;
> status = "okay";
> };
[Severity: High]
Is a boot phase tag also needed on the clock provider &scmi_clk for this UART?
Since phandle dependencies are stripped if not explicitly tagged, this could
cause clock acquisition to fail during SPL when &scmi_clk is missing from
the minified device tree.
[ ... ]
> @@ -1014,6 +1026,7 @@ &usdhc2 {
> pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
> vmmc-supply = <®_usdhc2_vmmc>;
> fsl,tuning-step = <1>;
> + bootph-pre-ram;
> status = "okay";
> };
[Severity: High]
Could the missing provider tag on &gpio3 also cause a regression here for
the card detect GPIO?
Since this node is marked for early boot but relies on &gpio3 via cd-gpios,
SPL might fail to acquire the GPIO if &gpio3 is excluded from the SPL DTB.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260814-bootph-frdm-imx95-v1-1-c0e3f1b9d2ed@nxp.com?part=1
next prev parent reply other threads:[~2026-08-14 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 6:32 [PATCH] arm64: dts: imx95-15x15-frdm: add boot phase properties Joseph Guo
2026-08-14 6:45 ` sashiko-bot [this message]
2026-08-14 6:49 ` [EXT] " Joseph Guo
2026-08-14 7:25 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814064514.ABD781F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=qijian.guo@nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox