[PATCH v2 1/1] ARM: dts: imx53: drop fallback compatible "dlg,da9052"

[PATCH v2 1/1] ARM: dts: imx53: drop fallback compatible "dlg,da9052"

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

The "dlg,da9053-aa" compatible string is not compatible with "dlg,da9052".

DA9052 vs DA9053-AA Differences (from da9052-regulator.c)
1. BUCK4 Voltage Range (only regulator table difference)
		DA9052 BUCK4	DA9053-AA BUCK4
Min voltage	1800 mV		950 mV
Max voltage	3600 mV		2525 mV
Step size	50 mV		25 mV

DA9052 BUCK4 also has a non-linear voltage mapping above 3V (step increases
to 100 mV for selector >= 24). DA9053-AA BUCK4 has no such special mapping.

2. BUCK Current Limits
Level	DA9052 (all BUCKs)	DA9053-AA BUCK1		DA9053-AA BUCK2/3/4
0	700 mA			1600 mA			800 mA
1	800 mA			2000 mA			1000 mA
2	1000 mA			2400 mA			1200 mA
3	1200 mA			3000 mA			1500 mA

DA9053-AA BUCK1 supports up to 3A (vs 1.2A on DA9052).

Drop the fallback compatible to fix the following CHECK_DTBS warning:

  dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Changes at v2
- update commit message.

Cc: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>

at thread
https://lore.kernel.org/imx/20260902-varied-unsent-b99f9f007685@spud/
Conor Dooley DA9052-AA is NOT compatible with DA9052.

I missed check da9052-regulator.c.

prevous kyrz ask drop the same patch at
https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/

Add commit message show why not compatible.
---
 arch/arm/boot/dts/nxp/imx/imx53-qsb.dts             | 2 +-
 arch/arm/boot/dts/nxp/imx/imx53-voipac-dmm-668.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts b/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
index 6831836bd726c..e7e15d2b82c44 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
@@ -13,7 +13,7 @@ / {
 
 &i2c1 {
 	pmic: dialog@48 {
-		compatible = "dlg,da9053-aa", "dlg,da9052";
+		compatible = "dlg,da9053-aa";
 		reg = <0x48>;
 		interrupt-parent = <&gpio7>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>; /* low-level active IRQ at GPIO7_11 */
diff --git a/arch/arm/boot/dts/nxp/imx/imx53-voipac-dmm-668.dtsi b/arch/arm/boot/dts/nxp/imx/imx53-voipac-dmm-668.dtsi
index 6dc70a92d831b..6eed683d92a83 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-voipac-dmm-668.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx53-voipac-dmm-668.dtsi
@@ -128,7 +128,7 @@ &i2c1 {
 	status = "okay";
 
 	pmic: dialog@48 {
-		compatible = "dlg,da9053-aa", "dlg,da9052";
+		compatible = "dlg,da9053-aa";
 		reg = <0x48>;
 		interrupt-parent = <&gpio7>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>; /* low-level active IRQ at GPIO7_11 */
-- 
2.43.0

Re: [PATCH v2 1/1] ARM: dts: imx53: drop fallback compatible "dlg,da9052"

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix for DA9052/DA9053 PMIC compatible string fallback mismatch
--

commit 421ff6545162f4ccc6bbeb14037dca411d6337a7
Author: Frank Li <Frank.Li@nxp.com>

ARM: dts: imx53: drop fallback compatible "dlg,da9052"

This commit drops the fallback compatible "dlg,da9052" from the
"dlg,da9053-aa" PMIC nodes in i.MX53 device trees. This prevents incorrect
voltage and current limits from being applied and fixes dtbs_check warnings.

Link: https://lore.kernel.org/imx/20260902-varied-unsent-b99f9f007685@spud/

> diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts b/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
> index 6831836bd726c..e7e15d2b82c44 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
> @@ -13,7 +13,7 @@ / {
>  
>  &i2c1 {
>  	pmic: dialog@48 {
> -		compatible = "dlg,da9053-aa", "dlg,da9052";
> +		compatible = "dlg,da9053-aa";
>  		reg = <0x48>;
>  		interrupt-parent = <&gpio7>;
>  		interrupts = <11 IRQ_TYPE_LEVEL_LOW>; /* low-level active IRQ at GPIO7_11 */

[Severity: High]
This is a pre-existing issue, but should this patch also update the PMIC
node in arch/arm/boot/dts/nxp/imx/imx53-smd.dts?

Looking at the smd device tree, it has a similar fallback configuration:

arch/arm/boot/dts/nxp/imx/imx53-smd.dts:pmic: dialog@48 {
    compatible = "dlg,da9053", "dlg,da9052";
    ...
}

Because the driver match tables do not contain the generic "dlg,da9053"
string, the core falls back to matching "dlg,da9052". This initializes the
driver with incorrect DA9052 regulator parameters for a DA9053 chip.

Could this expose the smd board to the same hardware risks (incorrect
voltage steps and current limits) described in the commit message? Would it
make sense to remove the fallback here as well to fully resolve the mismatch
across the imx53 boards?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902191324.2084035-1-Frank.Li@oss.nxp.com?part=1