* [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
@ 2026-09-08 21:54 Marek Vasut
2026-09-08 21:59 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2026-09-08 21:54 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Conor Dooley, Fabio Estevam, Frank Li,
Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, devicetree, imx, linux-kernel
Describe ID EEPROM nWP GPIO, label and nvmem layout. The i.MX8MM eDM SBC
and i.MX8MP eDM SBC nvmem layout is almost identical, except for length
of product-name@32 field, which is 19 Bytes on the Mini and 24 Bytes on
the Plus.
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
.../freescale/imx8mm-data-modul-edm-sbc.dts | 56 ++++++++
.../freescale/imx8mp-data-modul-edm-sbc.dts | 128 ++++++++++++++++++
2 files changed, 184 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
index df857de0375cf..2b7fed0c5a7c7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
@@ -431,7 +431,63 @@ usb-hub@2c {
eeprom: eeprom@50 {
compatible = "atmel,24c32";
reg = <0x50>;
+ label = "dmo-board-info";
pagesize = <32>;
+ wp-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+
+ nvmem-layout {
+ compatible = "fixed-layout";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ company-name@24 {
+ reg = <0x24 0xd>;
+ };
+
+ product-name@32 {
+ reg = <0x32 0x13>;
+ };
+
+ board-revision@4b {
+ reg = <0x4b 0x3>;
+ };
+
+ serial-number@4f {
+ reg = <0x4f 0x8>;
+ };
+
+ manufacturing-date@70 {
+ reg = <0x70 0xa>;
+ };
+
+ test-date@7b {
+ reg = <0x7b 0xa>;
+ };
+
+ product-number@86 {
+ reg = <0x86 0x8>;
+ };
+
+ board-variant@9a {
+ reg = <0x9a 0x9>;
+ };
+
+ company-acronym@a4 {
+ reg = <0xa4 0x3>;
+ };
+
+ mac-address@b0 {
+ reg = <0xb0 0x6>;
+ };
+
+ board-id@100 {
+ reg = <0x100 0x4>;
+ };
+
+ wifi-id@1200 {
+ reg = <0x120 0x4>;
+ };
+ };
};
rtc: rtc@68 {
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
index c284edfa1f4c8..1d03cf73588c4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
@@ -421,14 +421,142 @@ tpm: tpm@2e {
eeprom900: eeprom@50 { /* board rev.900 */
compatible = "atmel,24c32";
reg = <0x50>;
+ label = "dmo-board-info";
pagesize = <32>;
+ wp-gpios = <&gpio3 14 GPIO_ACTIVE_LOW>;
status = "disabled";
+
+ nvmem-layout {
+ compatible = "fixed-layout";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ company-name@24 {
+ reg = <0x24 0xd>;
+ };
+
+ product-name@32 {
+ reg = <0x32 0x18>;
+ };
+
+ board-revision@4b {
+ reg = <0x4b 0x3>;
+ };
+
+ serial-number@4f {
+ reg = <0x4f 0x8>;
+ };
+
+ manufacturing-date@70 {
+ reg = <0x70 0xa>;
+ };
+
+ test-date@7b {
+ reg = <0x7b 0xa>;
+ };
+
+ product-number@86 {
+ reg = <0x86 0x8>;
+ };
+
+ board-variant@9a {
+ reg = <0x9a 0x9>;
+ };
+
+ company-acronym@a4 {
+ reg = <0xa4 0x3>;
+ };
+
+ eeprom900mac: mac-address@b0 {
+ reg = <0xb0 0x6>;
+ };
+
+ board-id@100 {
+ reg = <0x100 0x4>;
+ };
+
+ wifi-id@1200 {
+ reg = <0x120 0x4>;
+ };
+
+ board-lvds-id@140 {
+ reg = <0x140 0x4>;
+ };
+
+ camera-id@160 {
+ reg = <0x160 0x4>;
+ };
+ };
};
eeprom902: eeprom@51 { /* board rev.902 */
compatible = "atmel,24c32";
reg = <0x51>;
+ label = "dmo-board-info";
pagesize = <32>;
+ wp-gpios = <&gpio3 14 GPIO_ACTIVE_LOW>;
+
+ nvmem-layout {
+ compatible = "fixed-layout";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ company-name@24 {
+ reg = <0x24 0xd>;
+ };
+
+ product-name@32 {
+ reg = <0x32 0x18>;
+ };
+
+ board-revision@4b {
+ reg = <0x4b 0x3>;
+ };
+
+ serial-number@4f {
+ reg = <0x4f 0x8>;
+ };
+
+ manufacturing-date@70 {
+ reg = <0x70 0xa>;
+ };
+
+ test-date@7b {
+ reg = <0x7b 0xa>;
+ };
+
+ product-number@86 {
+ reg = <0x86 0x8>;
+ };
+
+ board-variant@9a {
+ reg = <0x9a 0x9>;
+ };
+
+ company-acronym@a4 {
+ reg = <0xa4 0x3>;
+ };
+
+ eeprom902mac: mac-address@b0 {
+ reg = <0xb0 0x6>;
+ };
+
+ board-id@100 {
+ reg = <0x100 0x4>;
+ };
+
+ wifi-id@1200 {
+ reg = <0x120 0x4>;
+ };
+
+ board-lvds-id@140 {
+ reg = <0x140 0x4>;
+ };
+
+ camera-id@160 {
+ reg = <0x160 0x4>;
+ };
+ };
};
rtc: rtc@68 {
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
2026-09-08 21:54 [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout Marek Vasut
@ 2026-09-08 21:59 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-09-08 21:59 UTC (permalink / raw)
To: Marek Vasut; +Cc: robh, imx, devicetree, Frank.Li, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree unit address mismatch for `wifi-id` node
--
commit 082793f42f1059431835df44206b8d1014d852b6
Author: Marek Vasut <marex@nabladev.com>
arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
This commit describes the ID EEPROM nWP GPIO, label, and nvmem layout for
the i.MX8MM and i.MX8MP eDM SBCs.
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index 472c584fb3bd2..92df23e432499 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
[ ... ]
> + board-id@100 {
> + reg = <0x100 0x4>;
> + };
> +
> + wifi-id@1200 {
> + reg = <0x120 0x4>;
> + };
[Severity: Low]
Does this unit address mismatch the reg property? The node name uses 1200,
but the base address in the reg property is 120. This will likely cause a
dtc compiler warning for a simple-bus unit address format error.
> + };
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> index cb28cf1cdd23f..dbdf4b8f696f6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
[ ... ]
> + board-id@100 {
> + reg = <0x100 0x4>;
> + };
> +
> + wifi-id@1200 {
> + reg = <0x120 0x4>;
> + };
[Severity: Low]
Is the unit address 1200 a typo here as well? The reg property specifies 120
for the i.MX8MP SBC rev.900, which does not match the node name.
[ ... ]
> + board-id@100 {
> + reg = <0x100 0x4>;
> + };
> +
> + wifi-id@1200 {
> + reg = <0x120 0x4>;
> + };
[Severity: Low]
Similarly for the i.MX8MP SBC rev.902, should this unit address be updated
to match the 120 specified in the reg property?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908215519.33061-1-marex@nabladev.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-08 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-08 21:54 [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout Marek Vasut
2026-09-08 21:59 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).