From: sashiko-bot@kernel.org
To: "Francesco Dolcini" <francesco@dolcini.it>
Cc: robh@kernel.org, devicetree@vger.kernel.org, Frank.Li@kernel.org,
conor+dt@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
Date: Wed, 16 Sep 2026 08:46:38 +0000 [thread overview]
Message-ID: <20260916084639.7164E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916084025.274229-3-francesco@dolcini.it>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] dts: ABI breakage by renaming gpio-line-names on stable
--
commit 48f46109522a45af5619ecce5d2d589d31eef0e0
Author: Francesco Dolcini <francesco.dolcini@toradex.com>
arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
This commit renames the gpio3 line names from "DIG_1" and "DIG_2" to
"DIGI_1" and "DIGI_2" to match the official carrier board datasheet. It
also CCs stable for backporting.
Link: https://docs.toradex.com/116799-ivy_carrier_board_datasheet.pdf
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
> index db1b4ee7728c0..bf021e85cfc94 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
> @@ -333,8 +333,8 @@ &gpio3 {
> "",
> "",
> "",
> - "DIG_1", /* SODIMM 56 */
> - "DIG_2", /* SODIMM 58 */
> + "DIGI_1", /* SODIMM 56 */
> + "DIGI_2", /* SODIMM 58 */
[Severity: Critical]
Does this change break the userspace ABI?
The GPIO line names are exposed to userspace and relied upon by tooling
(like libgpiod). Because the old names ("DIG_1" and "DIG_2") have been
present in the kernel for some time, userspace applications may already be
using them.
Fixing the datasheet discrepancy by renaming established userspace-visible
names breaks these lookups. Furthermore, backporting this change to stable
branches will actively break existing production systems.
Is there a way to support the correct names without breaking existing users
relying on the older strings?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916084025.274229-1-francesco@dolcini.it?part=2
next prev parent reply other threads:[~2026-09-16 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 8:40 [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names Francesco Dolcini
2026-09-16 8:40 ` [PATCH v1 1/2] arm64: dts: freescale: imx8mm-verdin-ivy: " Francesco Dolcini
2026-09-16 8:40 ` [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: " Francesco Dolcini
2026-09-16 8:46 ` sashiko-bot [this message]
2026-09-23 19:55 ` [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: " Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916084639.7164E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox