Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
* [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
@ 2026-09-16  8:40 Francesco Dolcini
  2026-09-16  8:40 ` [PATCH v1 1/2] arm64: dts: freescale: imx8mm-verdin-ivy: " Francesco Dolcini
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Francesco Dolcini @ 2026-09-16  8:40 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
	linux-kernel

From: Francesco Dolcini <francesco.dolcini@toradex.com>

gpio-line-names names the two Ivy digital inputs "DIG_1" and
"DIG_2", while the official Ivy Carrier Board datasheet (Section 2.10,
Table 12) names them DIGI_1 and DIGI_2, matching the
k3-am62-verdin-ivy.dtsi variant for the same carrier board pins.

GPIO line names are meant to be stable across the whole Verdin family
and its carrier boards, so userspace GPIO tooling that looks up a line
by name works the same regardless of which Verdin SoM is fitted on
Ivy.

Link: https://docs.toradex.com/116799-ivy_carrier_board_datasheet.pdf

Francesco Dolcini (2):
  arm64: dts: freescale: imx8mm-verdin-ivy: fix DIGI_1/DIGI_2
    gpio-line-names
  arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2
    gpio-line-names

 arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++--
 arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.47.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 1/2] arm64: dts: freescale: imx8mm-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
  2026-09-16  8:40 [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names Francesco Dolcini
@ 2026-09-16  8:40 ` Francesco Dolcini
  2026-09-16  8:40 ` [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: " Francesco Dolcini
  2026-09-23 19:55 ` [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: " Frank.Li
  2 siblings, 0 replies; 5+ messages in thread
From: Francesco Dolcini @ 2026-09-16  8:40 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
	linux-kernel, stable

From: Francesco Dolcini <francesco.dolcini@toradex.com>

gpio3's gpio-line-names names the two Ivy digital inputs "DIG_1" and
"DIG_2", while the official Ivy Carrier Board datasheet (Section 2.10,
Table 12) names them DIGI_1 and DIGI_2, matching the
k3-am62-verdin-ivy.dtsi variant for the same carrier board pins.

GPIO line names are meant to be stable across the whole Verdin family
and its carrier boards, so userspace GPIO tooling that looks up a line
by name works the same regardless of which Verdin SoM is fitted on
Ivy.

Fixes: adca46171ff7 ("arm64: dts: freescale: imx8mm-verdin: Add Ivy carrier board")
Cc: stable@vger.kernel.org
Link: https://docs.toradex.com/116799-ivy_carrier_board_datasheet.pdf
Assisted-by: LLM
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
index 29075ff5eda6..b64751aa31d5 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
@@ -270,8 +270,8 @@ &gpio3 {
 		"",
 		"",
 		"",
-		"DIG_1", /* SODIMM 56 */
-		"DIG_2", /* SODIMM 58 */
+		"DIGI_1", /* SODIMM 56 */
+		"DIGI_2", /* SODIMM 58 */
 		"REL1",  /* SODIMM 60 */
 		"REL2",  /* SODIMM 62 */
 		"", /* 10 */
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
  2026-09-16  8:40 [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names Francesco Dolcini
  2026-09-16  8:40 ` [PATCH v1 1/2] arm64: dts: freescale: imx8mm-verdin-ivy: " Francesco Dolcini
@ 2026-09-16  8:40 ` Francesco Dolcini
  2026-09-16  8:46   ` sashiko-bot
  2026-09-23 19:55 ` [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: " Frank.Li
  2 siblings, 1 reply; 5+ messages in thread
From: Francesco Dolcini @ 2026-09-16  8:40 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
	linux-kernel, stable

From: Francesco Dolcini <francesco.dolcini@toradex.com>

gpio3's gpio-line-names names the two Ivy digital inputs "DIG_1" and
"DIG_2", while the official Ivy Carrier Board datasheet (Section 2.10,
Table 12) names them DIGI_1 and DIGI_2, matching the
k3-am62-verdin-ivy.dtsi variant for the same carrier board pins.

GPIO line names are meant to be stable across the whole Verdin family
and its carrier boards, so userspace GPIO tooling that looks up a line
by name works the same regardless of which Verdin SoM is fitted on
Ivy.

Fixes: b98948b04295 ("arm64: dts: freescale: imx8mp-verdin: Add Ivy carrier board")
Cc: stable@vger.kernel.org
Link: https://docs.toradex.com/116799-ivy_carrier_board_datasheet.pdf
Assisted-by: LLM
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
index db1b4ee7728c..bf021e85cfc9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
@@ -333,8 +333,8 @@ &gpio3 {
 		"",
 		"",
 		"",
-		"DIG_1", /* SODIMM 56 */
-		"DIG_2", /* SODIMM 58 */
+		"DIGI_1", /* SODIMM 56 */
+		"DIGI_2", /* SODIMM 58 */
 		"REL1",  /* SODIMM 60 */
 		"REL2",  /* SODIMM 62 */
 		"", /* 10 */
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
  2026-09-16  8:40 ` [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: " Francesco Dolcini
@ 2026-09-16  8:46   ` sashiko-bot
  0 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-09-16  8:46 UTC (permalink / raw)
  To: Francesco Dolcini; +Cc: robh, devicetree, Frank.Li, conor+dt, imx

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] dts: ABI breakage by renaming gpio-line-names on stable
--

commit 48f46109522a45af5619ecce5d2d589d31eef0e0
Author: Francesco Dolcini <francesco.dolcini@toradex.com>

arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names

This commit renames the gpio3 line names from "DIG_1" and "DIG_2" to
"DIGI_1" and "DIGI_2" to match the official carrier board datasheet. It
also CCs stable for backporting.

Link: https://docs.toradex.com/116799-ivy_carrier_board_datasheet.pdf

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
> index db1b4ee7728c0..bf021e85cfc94 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-ivy.dtsi
> @@ -333,8 +333,8 @@ &gpio3 {
>  		"",
>  		"",
>  		"",
> -		"DIG_1", /* SODIMM 56 */
> -		"DIG_2", /* SODIMM 58 */
> +		"DIGI_1", /* SODIMM 56 */
> +		"DIGI_2", /* SODIMM 58 */

[Severity: Critical]
Does this change break the userspace ABI?

The GPIO line names are exposed to userspace and relied upon by tooling
(like libgpiod). Because the old names ("DIG_1" and "DIG_2") have been
present in the kernel for some time, userspace applications may already be
using them.

Fixing the datasheet discrepancy by renaming established userspace-visible
names breaks these lookups. Furthermore, backporting this change to stable
branches will actively break existing production systems.

Is there a way to support the correct names without breaking existing users
relying on the older strings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916084025.274229-1-francesco@dolcini.it?part=2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
  2026-09-16  8:40 [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names Francesco Dolcini
  2026-09-16  8:40 ` [PATCH v1 1/2] arm64: dts: freescale: imx8mm-verdin-ivy: " Francesco Dolcini
  2026-09-16  8:40 ` [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: " Francesco Dolcini
@ 2026-09-23 19:55 ` Frank.Li
  2 siblings, 0 replies; 5+ messages in thread
From: Frank.Li @ 2026-09-23 19:55 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Francesco Dolcini
  Cc: Frank Li, Francesco Dolcini, devicetree, imx, linux-arm-kernel,
	linux-kernel

From: Frank Li <Frank.Li@nxp.com>


On Wed, 16 Sep 2026 10:40:21 +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> gpio-line-names names the two Ivy digital inputs "DIG_1" and
> "DIG_2", while the official Ivy Carrier Board datasheet (Section 2.10,
> Table 12) names them DIGI_1 and DIGI_2, matching the
> k3-am62-verdin-ivy.dtsi variant for the same carrier board pins.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: freescale: imx8mm-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
      commit: 28cec01a2be2cf1e20aabd435f250f665ce24c8e
[2/2] arm64: dts: freescale: imx8mp-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names
      commit: cb45264c27fad31f7c58fbb1a5c2f7ec16018dae

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-23 19:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16  8:40 [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: fix DIGI_1/DIGI_2 gpio-line-names Francesco Dolcini
2026-09-16  8:40 ` [PATCH v1 1/2] arm64: dts: freescale: imx8mm-verdin-ivy: " Francesco Dolcini
2026-09-16  8:40 ` [PATCH v1 2/2] arm64: dts: freescale: imx8mp-verdin-ivy: " Francesco Dolcini
2026-09-16  8:46   ` sashiko-bot
2026-09-23 19:55 ` [PATCH v1 0/2] arm64: dts: freescale: imx8m[mp]-verdin-ivy: " Frank.Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox