Re: [PATCH v4 1/3] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6563

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: phy: incomplete schema validation for microchip,ata6563
--

commit e1e7d148b2a5e6742f485d13055f3692d10dbf6a
Author: Marek Vasut <marex@nabladev.com>

dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6563

Microchip ATA6563 is High-Speed CAN Transceiver with Standby Mode.
It is pin-compatible with TI TCAN1042 and has a compatible programming
model, therefore use ti,tcan1042 as fallback compatible.

> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 9f5c37ca6496a..75c276548e122 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -18,6 +18,7 @@ properties:
>        - items:
>            - enum:
>                - microchip,ata6561
> +              - microchip,ata6563
>                - ti,tcan1051
>            - const: ti,tcan1042

[Severity: Medium]
Will this compatible string bypass the constraints enforced in the allOf block
below?

Since microchip,ata6563 is defined as an array item here, the compatible
property will be an array at runtime (e.g. ["microchip,ata6563",
"ti,tcan1042"]).

Looking at the allOf conditional block for ti,tcan1042:

allOf:
  - if:
      properties:
        compatible:
          enum:
            - nxp,tjr1443
            - ti,tcan1042
            - ti,tcan1043

This block uses an exact enum match. In JSON Schema, an array value will not
match this enum of single strings. 

Does this need to use contains: enum or contains: const to properly apply
constraints (like #phy-cells: const: 0) when a fallback array is used?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917062543.534416-1-marex@nabladev.com?part=1