Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Marek Vasut <marex@nabladev.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	robh@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev,
	conor+dt@kernel.org, Oliver Hartkopp <socketcan@hartkopp.net>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	linux-can@vger.kernel.org, Vincent Mailhol <mailhol@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC
Date: Mon, 21 Sep 2026 14:23:59 -0500	[thread overview]
Message-ID: <arGETwtIZxP3yOP1@SMW015318> (raw)
In-Reply-To: <abd334fb-22d4-4b71-9d44-4aa3c2789b79@nabladev.com>

On Mon, Sep 21, 2026 at 08:43:35PM +0200, Marek Vasut wrote:
> On 9/21/26 7:11 PM, Frank Li wrote:
>
> Hello Frank,
>
> > > > > > But why DTO need update regulator-panel-vcc's gpio informaiton. I suppose
> > > > > > it is fixed when board design.
> > > > >
> > > > > It is just a GPIO, it can have either polarity depending on the regulator
> > > > > that it controls.
> > > >
> > > > Understand, But the problem is why polarity change after board design?
> > > >
> > > > If reg_panel_vcc is on added on boards,  should it be in dtso file also to
> > > > match your hardware design correctly?
> > >
> > > We want to avoid duplication in the DTOs files, do we not ?
> >
> > Yes, but there are not dtso file yet, I don't know how to share it yet.
>
> Yes, there is no DTSO, because there is no DPU support for MX95, so display
> support in upstream is missing (check with Victor Liu, they might know more
> about the current state).
>
> > > Hence, base common stuff in the base DT, stuff that changes in the DTOs.
> >
> > Idea is good, but avoid hack stuff. Can you show me what's plan use
> > reg_panel_vcc in dtso and how to share it.
> See above, currently I cannot really use the regulator, because of the
> missing DPU support.

I suggest add it when it will be used.  Or Remove gpios = <&i2c2_gpio_expander_20 17 0>;

Suppose it will be overwrited by dtso future.

> The only DTO I temporarily have in tree (used with my
> DPU patchset) is for the RPi 7" display 2, which does not use this
> regulator.
>
> The plan is to use it the same way as on the MX8MM/MX8MP eDM SBC in the DTO:
>
> &reg_panel_vcc {
>   gpios = <&i2c2_gpio_expander_20 17 GPIO_ACTIVE_HIGH>;
>   enable-active-high;
>   status = "okay";
> };
>
> or
>
> &reg_panel_vcc {
>   gpios = <&i2c2_gpio_expander_20 17 GPIO_ACTIVE_LOW>;
>   status = "okay";
> };

In future, it should be nexus node for it and put reg_panel_vcc into dtso
files, and looks like you use gpio controller add-on boards's regulator.

Frank


  reply	other threads:[~2026-09-21 19:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  6:25 [PATCH v4 1/3] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6563 Marek Vasut
2026-09-17  6:25 ` [PATCH v4 2/3] dt-bindings: arm: fsl: Document Data Modul i.MX95 eDM SBC Marek Vasut
2026-09-18 11:01   ` Krzysztof Kozlowski
2026-09-17  6:25 ` [PATCH v4 3/3] arm64: dts: imx95: Add support for " Marek Vasut
2026-09-17  6:35   ` sashiko-bot
2026-09-17 16:53     ` Frank Li
2026-09-17 17:19       ` Marek Vasut
2026-09-17 18:46         ` Frank Li
2026-09-17 18:55           ` Marek Vasut
2026-09-18 13:58             ` Frank Li
2026-09-20 17:05               ` Marek Vasut
2026-09-21 16:24                 ` Frank Li
2026-09-21 16:37                   ` Marek Vasut
2026-09-21 17:11                     ` Frank Li
2026-09-21 18:43                       ` Marek Vasut
2026-09-21 19:23                         ` Frank Li [this message]
2026-09-21 21:46                           ` Marek Vasut
2026-09-17  6:31 ` [PATCH v4 1/3] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6563 sashiko-bot
2026-09-18 10:58 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arGETwtIZxP3yOP1@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-can@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=marex@nabladev.com \
    --cc=mkl@pengutronix.de \
    --cc=o.rempel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox