From: sashiko-bot@kernel.org
To: "Benjamin Gaignard" <benjamin.gaignard@collabora.com>
Cc: conor+dt@kernel.org, robh@kernel.org, imx@lists.linux.dev,
media-ci@linuxtv.org, devicetree@vger.kernel.org,
Frank.Li@kernel.org
Subject: Re: [PATCH v4 2/3] media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu
Date: Fri, 25 Sep 2026 08:56:52 +0000 [thread overview]
Message-ID: <20260925085653.528D51F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925085152.41852-3-benjamin.gaignard@collabora.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt-bindings: removing deprecated compatible nxp,imx8mq-vpu breaks validation for older DTBs
--
commit b108674bf1919c1736feafe71d426544535366fb
Author: Benjamin Gaignard <benjamin.gaignard@collabora.com>
media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu
This commit removes the deprecated nxp,imx8mq-vpu compatible string from
the bindings schema following a driver cleanup.
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> index 19528262810a5..69619d2c86fa0 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml
> @@ -14,12 +14,10 @@ description:
>
> properties:
> compatible:
> - oneOf:
> - - const: nxp,imx8mq-vpu
> - deprecated: true
[Severity: High]
Will removing this compatible string from the properties:compatible block
cause regressions during make dtbs_check validation for older device trees?
Since device tree bindings describe the hardware abi separately from the
Linux driver implementation, does the schema need to retain this entry
indefinitely with deprecated: true to preserve backward compatibility when
validating historically shipped device trees that still contain
compatible = "nxp,imx8mq-vpu"?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925085152.41852-1-benjamin.gaignard@collabora.com?part=2
next prev parent reply other threads:[~2026-09-25 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 8:51 [PATCH v4 0/3] media: verisilicon: remove unused variant and code clean up Benjamin Gaignard
2026-09-25 8:51 ` [PATCH v4 1/3] media: verisilicon: Remove deprecated variant Benjamin Gaignard
2026-09-25 9:04 ` sashiko-bot
2026-09-25 15:03 ` Frank Li
2026-09-25 8:51 ` [PATCH v4 2/3] media: dt-bindings: media: nxp, imx8mq-vpu: Remove nxp,imx8mq-vpu Benjamin Gaignard
2026-09-25 8:56 ` sashiko-bot [this message]
2026-09-25 16:45 ` Conor Dooley
2026-09-25 8:51 ` [PATCH v4 3/3] media: verisilicon: Remove useless internal fields Benjamin Gaignard
2026-09-25 8:58 ` sashiko-bot
2026-09-25 15:05 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925085653.528D51F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox