Re: [PATCH v4 3/3] media: verisilicon: Remove useless internal fields

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] doc: orphaned kernel-doc parameter for removed struct member ctrl_base
--

commit 5392510f52daeba396b90c138e1c5e648a91c573
Author: Benjamin Gaignard <benjamin.gaignard@collabora.com>

media: verisilicon: Remove useless internal fields

This commit simplifies the driver by removing multiple register regions
and useless internal fields. It renames reg_bases to reg_base and removes
unused members like ctrl_base from struct hantro_dev.

> diff --git a/drivers/media/platform/verisilicon/hantro.h b/drivers/media/platform/verisilicon/hantro.h
> index 0353de154a1ec..ca03bc690fbf8 100644
> --- a/drivers/media/platform/verisilicon/hantro.h
> +++ b/drivers/media/platform/verisilicon/hantro.h
[ ... ]
> @@ -184,7 +180,7 @@ hantro_vdev_to_func(struct video_device *vdev)
>   *			dev_ macros.
>   * @clocks:		Array of clock handles.
>   * @resets:		Array of reset handles.
> - * @reg_bases:		Mapped addresses of VPU registers.
> + * @reg_base:		Mapped address of VPU registers.
>   * @enc_base:		Mapped address of VPU encoder register for convenience.
>   * @dec_base:		Mapped address of VPU decoder register for convenience.
>   * @ctrl_base:		Mapped address of VPU control block.

[Severity: Low]
Does this leave an orphaned kernel-doc entry? The patch removes the ctrl_base
member from struct hantro_dev below, but leaves its documentation parameter 
here, which might trigger a kernel-doc script warning.

> @@ -204,10 +200,9 @@ struct hantro_dev {
>  	struct device *dev;
>  	struct clk_bulk_data *clocks;
>  	struct reset_control *resets;
> -	void __iomem **reg_bases;
> +	void __iomem *reg_base;
>  	void __iomem *enc_base;
>  	void __iomem *dec_base;
> -	void __iomem *ctrl_base;
>  
>  	struct mutex vpu_mutex;	/* video_device lock */
>  	spinlock_t irqlock;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925085152.41852-1-benjamin.gaignard@collabora.com?part=3