Re: EXTERNAL - [PATCH v3] arm64: dts: imx8mm-verdin: Link reg_usdhc2_vqmmc to usdhc2

[Philippe Schenker <philippe.schenker@impulsing.ch>]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]



On Thu, 2025-04-24 at 08:16 +0200, Wojciech Dubowik wrote:
> On Wed, Apr 23, 2025 at 11:23:09AM +0000, Philippe Schenker wrote:
> > On Wed, 2025-04-23 at 12:21 +0200, Francesco Dolcini wrote:
> > > > > 
> > > > > I would backport this to also older kernel, so to me
> > > > > 
> > > > > Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial
> > > > > support
> > > > > for
> > > > > verdin imx8m mini")
> > > > 
> > > > NACK for the proposed Fixes, this introduces a new Kconfig
> > > > which
> > > > could
> > > > have side-effects in users of current stable kernels.
> > > 
> > > The driver for "regulator-gpio" compatible? I do not agree with
> > > your
> > > argument,
> > > sorry. 
> > > 
> > > The previous description was not correct. There was an unused
> > > regulator in the DT that was not switched off just by chance.
> > > 
> > > Francesco
> > > 
> > My previous reasoning about the driver is one point. The other is
> > that
> > the initial implementation in 6a57f224f734 ("arm64: dts: freescale:
> > add
> > initial support for verdin imx8m mini") was not wrong at all it was
> > just different.
> > 
> > My concern is for existing users of stable kernels that you change
> > the
> > underlying implementation of how the SD voltage gets switched. And
> > adding the tag
> > 
> > 
> > Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support
> > for
> > verdin imx8m mini")
> > 
> > to this patch would get this new implementation also to stable
> > kernels
> > not affected by the issue introduced in f5aab0438ef1 ("regulator:
> > pca9450: Fix enable register for LDO5")
> 
> I will wait a day and send V4 with what I beleive was result of this
> discussion.

Sorry if it was confusing. I'm perfectly fine with your v3. I was just
not agreeing with the Fixes-Tag proposed by Francesco.

> 
> Wojtek
> 
> > 
> > Philippe
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 717 bytes --]