Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Philippe Schenker <philippe.schenker@impulsing.ch>
To: Francesco Dolcini <francesco@dolcini.it>,
	Wojciech Dubowik <Wojciech.Dubowik@mt.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: EXTERNAL - [PATCH v3] arm64: dts: imx8mm-verdin: Link reg_usdhc2_vqmmc to usdhc2
Date: Thu, 24 Apr 2025 09:24:16 +0000	[thread overview]
Message-ID: <84dc6fdf295902044d49cafc4479eb75477bba5c.camel@impulsing.ch> (raw)
In-Reply-To: <aAn3qBG0ckInWvs1@gaggiata.pivistrello.it>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

On Thu, 2025-04-24 at 10:34 +0200, Francesco Dolcini wrote:
> > > 
> > > My opinion is that we should backport this fix. The DT
> > > description
> > > was
> > > wrong, that change on the PMIC driver just made the issue
> > > visible,
> > > the DT is about the HW description.
> > 
> > From what I understand it was not wrong but it became wrong with
> > the
> > PMIC driver changes.
> 
> It was wrong. You had a regulator described as not used, and
> therefore the OS
> was free to switch it off. For a bug in the driver this regulator was
> not
> switched off by the old kernels.
> 
> The DT description was never correct.
> 
> With that said, hopefully it makes no difference in pratice,
> f5aab0438ef17f01c5ecd25e61ae6a03f82a4586 will be backported, and
> therefore also
> any fix to it should.

Aah I overlooked the Fixes: tag there. Yes in this case we need your
Fixes tag, you are of course correct as always.

@Wojciech, please send a v4 with:

Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for
verdin imx8m mini")

Philippe

> 
> If for some unfortunate reason we do not backport also this one,
> you'll get a
> non-working SD card on your LTS kernel.
> 
> Francesco

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 717 bytes --]

  reply	other threads:[~2025-04-24  9:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 14:01 [PATCH v3] arm64: dts: imx8mm-verdin: Link reg_usdhc2_vqmmc to usdhc2 Wojciech Dubowik
2025-04-23  6:00 ` Manuel Traut
2025-04-23  9:53 ` Francesco Dolcini
2025-04-23 10:16   ` Philippe Schenker
2025-04-23 10:21     ` Francesco Dolcini
2025-04-23 11:23       ` Philippe Schenker
2025-04-24  6:16         ` EXTERNAL - " Wojciech Dubowik
2025-04-24  7:21           ` Francesco Dolcini
2025-04-24  8:20             ` Philippe Schenker
2025-04-24  8:34               ` Francesco Dolcini
2025-04-24  9:24                 ` Philippe Schenker [this message]
2025-04-24  8:07           ` Philippe Schenker
2025-04-24  8:26 ` Philippe Schenker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84dc6fdf295902044d49cafc4479eb75477bba5c.camel@impulsing.ch \
    --to=philippe.schenker@impulsing.ch \
    --cc=Wojciech.Dubowik@mt.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox