* [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset
@ 2024-07-03 12:04 Sascha Hauer
2024-07-03 12:15 ` Fabio Estevam
2024-07-03 12:40 ` Alexander Stein
0 siblings, 2 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-07-03 12:04 UTC (permalink / raw)
To: linux-arm-kernel
Cc: imx, Rob Herring, Krzysztof Kozlowski, Shawn Guo, linux,
Pengutronix Kernel Team, Conor Dooley, Sascha Hauer
On the tqma9352 the board is reset through an external PMIC, so
set the fsl,ext-reset-output property to enable triggering the
output pin on a watchdog trigger.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
index 9d2328c185c90..e9d89b4bbba04 100644
--- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
@@ -151,6 +151,7 @@ &wdog3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
status = "okay";
+ fsl,ext-reset-output;
};
&iomuxc {
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset
2024-07-03 12:04 [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset Sascha Hauer
@ 2024-07-03 12:15 ` Fabio Estevam
2024-07-03 12:40 ` Alexander Stein
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-07-03 12:15 UTC (permalink / raw)
To: Sascha Hauer
Cc: linux-arm-kernel, imx, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, linux, Pengutronix Kernel Team, Conor Dooley
Hi Sascha,
On Wed, Jul 3, 2024 at 9:05 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
> @@ -151,6 +151,7 @@ &wdog3 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wdog>;
> status = "okay";
> + fsl,ext-reset-output;
Nitpick: it is preferred to keep status as the last entry.
Other than that:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset
2024-07-03 12:04 [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset Sascha Hauer
2024-07-03 12:15 ` Fabio Estevam
@ 2024-07-03 12:40 ` Alexander Stein
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2024-07-03 12:40 UTC (permalink / raw)
To: linux-arm-kernel, Sascha Hauer
Cc: imx, Rob Herring, Krzysztof Kozlowski, Shawn Guo, linux,
Pengutronix Kernel Team, Conor Dooley, Sascha Hauer
Hi Sascha,
thanks for the patch.
Am Mittwoch, 3. Juli 2024, 14:04:09 CEST schrieb Sascha Hauer:
> On the tqma9352 the board is reset through an external PMIC, so
> set the fsl,ext-reset-output property to enable triggering the
> output pin on a watchdog trigger.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index 9d2328c185c90..e9d89b4bbba04 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -151,6 +151,7 @@ &wdog3 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wdog>;
> status = "okay";
> + fsl,ext-reset-output;
As Fabio mentioned, status is the last property. With that fixed:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> };
>
> &iomuxc {
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-03 12:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-03 12:04 [PATCH] arm64: dts: freescale: tqma9352: Fix watchdog reset Sascha Hauer
2024-07-03 12:15 ` Fabio Estevam
2024-07-03 12:40 ` Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox