[PATCH 0/3] arm64: dts: freescale: moduline-display: several fixes

[PATCH 0/3] arm64: dts: freescale: moduline-display: several fixes

[Maud Spierings via B4 Relay]

A couple of issues where discovered:
- compatibles should integrate the SoM
- the eqos mac address is stored in eth_mac1

The first one is breaking, but it is early enough that it can be
corrected without causing any issues.

Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
Maud Spierings (3):
      dt-bindings: arm: fsl: moduline-display: fix compatible
      arm64: dts: freescale: moduline-display: fix compatible
      arm64: dts: freescale: tx8p-ml81: fix eqos nvmem-cells

 Documentation/devicetree/bindings/arm/fsl.yaml                     | 7 ++++++-
 .../boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106.dts   | 2 +-
 arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi                | 5 +++++
 3 files changed, 12 insertions(+), 2 deletions(-)
---
base-commit: 0f2995693867bfb26197b117cd55624ddc57582f
change-id: 20251114-disp_fix-2c90d35ab0dd

Best regards,
-- 
Maud Spierings <maudspierings@gocontroll.com>

[PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible

[Maud Spierings via B4 Relay]

From: Maud Spierings <maudspierings@gocontroll.com>

The compatibles should include the SoM compatible, this board is based
on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
the board compatible.

This is a breaking change, but it is early enough that it can be
corrected without causing any issues.

Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 21b7168d61f5..8949a98acd87 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1105,7 +1105,6 @@ properties:
               - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
               - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
               - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
-              - gocontroll,moduline-display # GOcontroll Moduline Display controller
               - prt,prt8ml             # Protonic PRT8ML
               - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
               - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
@@ -1163,6 +1162,12 @@ properties:
           - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
           - const: fsl,imx8mp
 
+      - description: Ka-Ro TX8P-ML81 SoM based boards
+        items:
+          - const: gocontroll,moduline-display-106
+          - const: karo,tx8p-ml81
+          - const: fsl,imx8mp
+
       - description: Kontron i.MX8MP OSM-S SoM based Boards
         items:
           - const: kontron,imx8mp-bl-osm-s  # Kontron BL i.MX8MP OSM-S Board

-- 
2.51.2

Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible

[Krzysztof Kozlowski]

On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
> The compatibles should include the SoM compatible, this board is based
> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
> the board compatible.
> 
> This is a breaking change, but it is early enough that it can be
> corrected without causing any issues.
> 
> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 21b7168d61f5..8949a98acd87 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1105,7 +1105,6 @@ properties:
>                - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>                - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>                - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>                - prt,prt8ml             # Protonic PRT8ML
>                - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>                - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
> @@ -1163,6 +1162,12 @@ properties:
>            - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>            - const: fsl,imx8mp
>  
> +      - description: Ka-Ro TX8P-ML81 SoM based boards
> +        items:
> +          - const: gocontroll,moduline-display-106

You need old compatible here as well, you cannot drop it.

I don't understand why you need board revision - commit msg should
explain that.

> +          - const: karo,tx8p-ml81
> +          - const: fsl,imx8mp

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible

[Maud Spierings]

Hi Krzysztof,

Thanks for the review.

On 11/15/25 12:53, Krzysztof Kozlowski wrote:
> On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
>> The compatibles should include the SoM compatible, this board is based
>> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
>> the board compatible.
>>
>> This is a breaking change, but it is early enough that it can be
>> corrected without causing any issues.
>>
>> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
>> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
>> ---
>>   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 21b7168d61f5..8949a98acd87 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1105,7 +1105,6 @@ properties:
>>                 - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>>                 - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>>                 - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
>> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>>                 - prt,prt8ml             # Protonic PRT8ML
>>                 - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>>                 - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
>> @@ -1163,6 +1162,12 @@ properties:
>>             - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>>             - const: fsl,imx8mp
>>   
>> +      - description: Ka-Ro TX8P-ML81 SoM based boards
>> +        items:
>> +          - const: gocontroll,moduline-display-106
> 
> You need old compatible here as well, you cannot drop it.

The old compatible should stay in the above section then right? Because 
the old compatible never matched the pattern with the SoM compatible. 
Should/can I add some deprecated tag to it then?

> I don't understand why you need board revision - commit msg should
> explain that.

It is to resolve certain quirks in userspace/bootloader, I will add it 
to the commit version in the next version.

The SoM compatible will be used in barebox to trigger shared code that 
applies to this SoM, I will add that better to the commit message too. I 
believe that also resolves the comments on patch 2/3

Kind Regards,
Maud
>> +          - const: karo,tx8p-ml81
>> +          - const: fsl,imx8mp
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible

[Krzysztof Kozlowski]

On 17/11/2025 08:33, Maud Spierings wrote:
> Hi Krzysztof,
> 
> Thanks for the review.
> 
> On 11/15/25 12:53, Krzysztof Kozlowski wrote:
>> On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
>>> The compatibles should include the SoM compatible, this board is based
>>> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
>>> the board compatible.
>>>
>>> This is a breaking change, but it is early enough that it can be
>>> corrected without causing any issues.
>>>
>>> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
>>> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
>>> ---
>>>   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 21b7168d61f5..8949a98acd87 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1105,7 +1105,6 @@ properties:
>>>                 - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>>>                 - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>>>                 - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
>>> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>>>                 - prt,prt8ml             # Protonic PRT8ML
>>>                 - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>>>                 - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
>>> @@ -1163,6 +1162,12 @@ properties:
>>>             - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>>>             - const: fsl,imx8mp
>>>   
>>> +      - description: Ka-Ro TX8P-ML81 SoM based boards
>>> +        items:
>>> +          - const: gocontroll,moduline-display-106
>>
>> You need old compatible here as well, you cannot drop it.
> 
> The old compatible should stay in the above section then right? Because 
> the old compatible never matched the pattern with the SoM compatible. 
> Should/can I add some deprecated tag to it then?

You could deprecate old list but there is little benefit of it, but the
point is that your final (new) list must include old compatible because
otherwise it is a potential ABI break.



Best regards,
Krzysztof

[PATCH 2/3] arm64: dts: freescale: moduline-display: fix compatible

[Maud Spierings via B4 Relay]

From: Maud Spierings <maudspierings@gocontroll.com>

The compatibles should include the SoM compatible, this board is based
on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
the board compatible.

This is a breaking change, but it is early enough that it can be
corrected without causing any issues.

Fixes: 03f07be54cdc ("arm64: dts: freescale: Add the GOcontroll Moduline Display baseboard")
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106.dts b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106.dts
index 88ad422c2760..399230144ce3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106.dts
@@ -9,7 +9,7 @@
 #include "imx8mp-tx8p-ml81.dtsi"
 
 / {
-	compatible = "gocontroll,moduline-display", "fsl,imx8mp";
+	compatible = "gocontroll,moduline-display-106", "karo,tx8p-ml81", "fsl,imx8mp";
 	chassis-type = "embedded";
 	hardware = "Moduline Display V1.06";
 	model = "GOcontroll Moduline Display baseboard";

-- 
2.51.2

Re: [PATCH 2/3] arm64: dts: freescale: moduline-display: fix compatible

[Krzysztof Kozlowski]

On Fri, Nov 14, 2025 at 03:11:50PM +0100, Maud Spierings wrote:
> The compatibles should include the SoM compatible, this board is based
> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
> the board compatible.
> 
> This is a breaking change, but it is early enough that it can be
> corrected without causing any issues.

You did not describe what is here wrong that it needs a correction.

Best regards,
Krzysztof

[PATCH 3/3] arm64: dts: freescale: tx8p-ml81: fix eqos nvmem-cells

[Maud Spierings via B4 Relay]

From: Maud Spierings <maudspierings@gocontroll.com>

On this SoM eqos is the primary ethernet interface, Ka-Ro fuses the
address for it in eth_mac1, eth_mac2 seems to be left unfused. In their
downstream u-boot they fetch it from eth_mac1 [1][2], by setting alias
of eqos to ethernet0, the driver then fetches the mac address based on
the alias number.

Set eqos to read from eth_mac1 instead of eth_mac2. Also set fec to
point at eth_mac2 as it may be fused later even though it is disabled
by default.

With this changed barebox is now capable of loading the correct address.

Link: https://github.com/karo-electronics/karo-tx-uboot/blob/380543278410bbf04264d80a3bfbe340b8e62439/drivers/net/dwc_eth_qos.c#L1167 [1]
Link: https://github.com/karo-electronics/karo-tx-uboot/blob/380543278410bbf04264d80a3bfbe340b8e62439/arch/arm/dts/imx8mp-karo.dtsi#L12 [2]

Fixes: bac63d7c5f46 ("arm64: dts: freescale: add Ka-Ro Electronics tx8p-ml81 COM")
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi
index fe8ba16eb40e..761ee046eb72 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi
@@ -47,6 +47,7 @@ &eqos {
 				 <&clk IMX8MP_SYS_PLL2_100M>,
 				 <&clk IMX8MP_SYS_PLL2_50M>;
 	assigned-clock-rates = <266000000>, <100000000>, <50000000>;
+	nvmem-cells = <&eth_mac1>;
 	phy-handle = <&ethphy0>;
 	phy-mode = "rmii";
 	pinctrl-0 = <&pinctrl_eqos>;
@@ -75,6 +76,10 @@ ethphy0: ethernet-phy@0 {
 	};
 };
 
+&fec {
+	nvmem-cells = <&eth_mac2>;
+};
+
 &gpio1 {
 	gpio-line-names = "SODIMM_152",
 			  "SODIMM_42",

-- 
2.51.2