From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
NXP S32 Linux Team <s32@nxp.com>,
Radu Pirea <radu-nicolae.pirea@nxp.com>
Subject: Re: [PATCH v2 1/2] arm64: dts: s32g: Add S32G2/S32G3 uSDHC pinmux
Date: Wed, 18 Sep 2024 12:58:03 +0300 [thread overview]
Message-ID: <6284ad03-bf31-4096-b62f-12fb888683af@oss.nxp.com> (raw)
In-Reply-To: <f2660611-6f60-4913-8705-e99956ab23b0@kernel.org>
On 9/17/2024 8:44 PM, Krzysztof Kozlowski wrote:
> On 30/08/2024 13:33, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> Adding 100mhz & 200mhz pinmux support for uSDHC helps to enable
>> higher speed modes for SD (SDR50, DDR50, SDR104) and
>> eMMC (such as HS200, HS400/HS400ES).
>>
>> Signed-off-by: Radu Pirea <radu-nicolae.pirea@nxp.com>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/s32g2.dtsi | 153 ++++++++++++++++++
>> .../arm64/boot/dts/freescale/s32g274a-evb.dts | 4 +
>> .../boot/dts/freescale/s32g274a-rdb2.dts | 4 +
>> arch/arm64/boot/dts/freescale/s32g3.dtsi | 153 ++++++++++++++++++
>> .../boot/dts/freescale/s32g399a-rdb3.dts | 4 +
>> 5 files changed, 318 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi
>> index fa054bfe7d5c..7be430b78c83 100644
>> --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi
>> @@ -162,6 +162,159 @@ jtag-grp4 {
>> slew-rate = <166>;
>> };
>> };
>> +
>> + pinctrl_usdhc0: usdhc0grp-pins {
>> + usdhc0-grp0 {
>
> Are you sure that this passes dtbs_check W=1?
>
> Best regards,
> Krzysztof
>
Hello Krzysztof,
I've checked as follows:
$ make ARCH=arm64 CHECK_DTBS=y W=1 freescale/s32g274a-evb.dtb
freescale/s32g274a-rdb2.dtb freescale/s32g399a-rdb3.dtb
DTC [C] arch/arm64/boot/dts/freescale/s32g274a-evb.dtb
DTC [C] arch/arm64/boot/dts/freescale/s32g274a-rdb2.dtb
DTC [C] arch/arm64/boot/dts/freescale/s32g399a-rdb3.dtb
Best Regards,
Ciprian
next prev parent reply other threads:[~2024-09-18 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 11:33 [PATCH v2 0/2] add S32G2/S32G3 uSDHC pinmux Ciprian Costea
2024-08-30 11:33 ` [PATCH v2 1/2] arm64: dts: s32g: Add " Ciprian Costea
2024-09-06 15:53 ` Matthias Brugger
2024-09-17 17:44 ` Krzysztof Kozlowski
2024-09-18 9:58 ` Ciprian Marian Costea [this message]
2024-08-30 11:33 ` [PATCH v2 2/2] arm64: dts: s32g2: Disable support for SD/eMMC UHS mode Ciprian Costea
2024-09-06 15:53 ` Matthias Brugger
2024-10-08 9:25 ` [PATCH v2 0/2] add S32G2/S32G3 uSDHC pinmux Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6284ad03-bf31-4096-b62f-12fb888683af@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=radu-nicolae.pirea@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox