[PATCH] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware

[PATCH] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware

[Bratiranjan Acharya]

imx_get_se_data_info() returns NULL during early boot because the
EdgeLock Enclave firmware takes ~900ms to register its services.
Returning -ENODEV here permanently drops the driver with no retry,
leaving DDR DVFS and lpm-cooling non-functional.

Return -EPROBE_DEFER so the driver retries once SE firmware is up.

Tested on i.MX93: probe defers once, succeeds on retry, lpm-cooling
and DDR frequency scaling both operational.

Fixes: 711990e353bb ("LF-13910: soc: imx93: lpm changes to update exported apis")
Signed-off-by: Bratiranjan Acharya <bacharya@enphaseenergy.com>
---
 drivers/soc/imx/imx93_lpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/imx93_lpm.c b/drivers/soc/imx/imx93_lpm.c
index bfa52ff8f..26d72e3e2 100644
--- a/drivers/soc/imx/imx93_lpm.c
+++ b/drivers/soc/imx/imx93_lpm.c
@@ -621,7 +621,7 @@ static int imx93_lpm_probe(struct platform_device *pdev)
 	se_data = imx_get_se_data_info(SOC_ID_OF_IMX93, 0);
 	if (!se_data) {
 		dev_err(&pdev->dev, "get se-fw2 failed\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 
 	/*
-- 
2.34.1

RE: [PATCH] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE firmware

[Peng Fan]

> Subject: [PATCH] soc: imx: imx93_lpm: return -EPROBE_DEFER when SE
> firmware

Oh. This is for nxp release tree.

>
> imx_get_se_data_info() returns NULL during early boot because the
> EdgeLock Enclave firmware takes ~900ms to register its services.
> Returning -ENODEV here permanently drops the driver with no retry,
> leaving DDR DVFS and lpm-cooling non-functional.
>
> Return -EPROBE_DEFER so the driver retries once SE firmware is up.
>
> Tested on i.MX93: probe defers once, succeeds on retry, lpm-cooling
> and DDR frequency scaling both operational.
>
> Fixes: 711990e353bb ("LF-13910: soc: imx93: lpm changes to update
> exported apis")
> Signed-off-by: Bratiranjan Acharya <bacharya@enphaseenergy.com>

Looks good to me.

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/soc/imx/imx93_lpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx93_lpm.c
> b/drivers/soc/imx/imx93_lpm.c index bfa52ff8f..26d72e3e2 100644
> --- a/drivers/soc/imx/imx93_lpm.c
> +++ b/drivers/soc/imx/imx93_lpm.c
> @@ -621,7 +621,7 @@ static int imx93_lpm_probe(struct
> platform_device *pdev)
>         se_data = imx_get_se_data_info(SOC_ID_OF_IMX93, 0);
>         if (!se_data) {
>                 dev_err(&pdev->dev, "get se-fw2 failed\n");
> -               return -ENODEV;
> +               return -EPROBE_DEFER;
>         }
>
>         /*
> --
> 2.34.1

NXP Confidential